Skip to content

refactor(oxc): ban index methods on std::str::Chars #6075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 2 commits into from
Oct 10, 2024
Merged

refactor(oxc): ban index methods on std::str::Chars #6075

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
100b0cd
refactor(oxc): ban index methods on std::str::Chars
shulaoda Sep 26, 2024
b5dee29
chore(ci): add check
shulaoda Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor(oxc): ban index methods on std::str::Chars
  • Loading branch information
@shulaoda @Boshen
shulaoda authored and Boshen committed Oct 10, 2024
commit 100b0cdf4627c29d8c24f07452251e55553493b9
4 changes: 2 additions & 2 deletions crates/oxc_linter/src/rules/nextjs/no_typos.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,9 @@ fn min_distance(a: &str, b: &str) -> usize {

let mut previous_row: Vec<usize> = (0..=n).collect();

for (i, s1) in a.chars().enumerate() {
for (i, s1) in a.char_indices() {
let mut current_row = vec![i + 1];
for (j, s2) in b.chars().enumerate() {
for (j, s2) in b.char_indices() {
let insertions = previous_row[j + 1] + 1;
let deletions = current_row[j] + 1;
let substitutions = previous_row[j] + usize::from(s1 != s2);
Expand Down