Skip to content

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Sep 30, 2024

closes #6172

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler labels Sep 30, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 30, 2024

CodSpeed Performance Report

Merging #6173 will not alter performance

Comparing shulaoda:refactor/transformer-transform-ctx (e049c50) with main (f2ac584)

Summary

✅ 29 untouched benchmarks

@shulaoda
Copy link
Member Author

Could you reopen this PR? 😂 @Dunqing

@Boshen Boshen reopened this Sep 30, 2024
@shulaoda shulaoda force-pushed the refactor/transformer-transform-ctx branch from 9e7267d to 51a937a Compare September 30, 2024 06:44
@Dunqing
Copy link
Member

Dunqing commented Sep 30, 2024

Sorry, I tagged wrong

Copy link
Member

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing this.

Apart from the comment above about reverting traverse_mut to how it was, looks great.

Please could make that change and ping me, so I can do a final review and merge it ASAP before we get merge conflicts?

@overlookmotel
Copy link
Member

@shulaoda This has merge conflicts and I was worried that if I requested changes, there'd be more merge conflicts again by the time I got to reviewing your changes (probably we are in different time zones, and this PR touches a lot of files in the transformer, which is currently under heavy development).

So I have taken the liberty of rebasing this on latest main, fixing the problem discussed above, and merging it.

Sorry if it feels like I've taken over your work. I just really didn't want to waste your time going back-and-forwards endlessly dealing with merge conflicts. Really appreciate your work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor transformer to use the instance of AstBuilder which is in TraverseCtx everywhere

4 participants