-
-
Notifications
You must be signed in to change notification settings - Fork 760
refactor(transformer): use AstBuilder instance from TraverseCtx
#6173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(transformer): use AstBuilder instance from TraverseCtx
#6173
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #6173 will not alter performanceComparing Summary
|
3be28c0 to
9e7267d
Compare
|
Could you reopen this PR? 😂 @Dunqing |
9e7267d to
51a937a
Compare
|
Sorry, I tagged wrong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for doing this.
Apart from the comment above about reverting traverse_mut to how it was, looks great.
Please could make that change and ping me, so I can do a final review and merge it ASAP before we get merge conflicts?
|
@shulaoda This has merge conflicts and I was worried that if I requested changes, there'd be more merge conflicts again by the time I got to reviewing your changes (probably we are in different time zones, and this PR touches a lot of files in the transformer, which is currently under heavy development). So I have taken the liberty of rebasing this on latest main, fixing the problem discussed above, and merging it. Sorry if it feels like I've taken over your work. I just really didn't want to waste your time going back-and-forwards endlessly dealing with merge conflicts. Really appreciate your work on this. |
closes #6172