Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Oct 5, 2024

Move post-transform checker into a tasks crate. It doesn't feel like it belongs in oxc_semantic. It also feels like too heavy a lump of code to put in tasks/common.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler labels Oct 5, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 5, 2024

CodSpeed Performance Report

Merging #6288 will not alter performance

Comparing 10-04-ci_transformer_move_post-transform_checker_to_tasks_crate (e19deaa) with main (0f5afd7)

Summary

✅ 29 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 10-05-test_transformer_tidy_up_transform_checker branch from 1723b84 to bff3151 Compare October 5, 2024 12:12
@overlookmotel overlookmotel force-pushed the 10-04-ci_transformer_move_post-transform_checker_to_tasks_crate branch 2 times, most recently from 2019ad0 to 466bb0b Compare October 5, 2024 13:19
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 5, 2024 — with Graphite App
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 5, 2024

Merge activity

Move post-transform checker into a `tasks` crate. It doesn't feel like it belongs in `oxc_semantic`. It also feels like too heavy a lump of code to put in `tasks/common`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants