fix(linter): no-else-return fixer fails when else has no trailing whitespace

[DonIsaac]

Fixes a bug in eslint/no_else_return's fixer where fixes were not being
property applied when else had no whitespace immediately after it. For
example:

if(x){ return x }else{ return y }

I also refactored the rule's fixer to avoid string allocations as much as
possible.

[DonIsaac]

• fix(linter): friendly diagnostic messages for no-else-return #6349
• fix(linter): no-else-return fixer fails when else has no trailing whitespace #6348 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[codspeed-hq]

CodSpeed Performance Report

Merging #6348 will not alter performance

_{Comparing don/10-07-fix_linter_no_else_return_fixer_fails_when_else_has_no_trailing_whitespace (71ad5d3) with main (a1e0d30)}

Summary

✅ 29 untouched benchmarks

[graphite-app]

Merge activity

• Oct 7, 7:19 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Oct 7, 7:19 PM EDT: DonIsaac added this pull request to the Graphite merge queue.
• Oct 7, 7:24 PM EDT: DonIsaac merged this pull request with the Graphite merge queue.