Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Oct 10, 2024

i am testing to see why perf dropped so much in #6424

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

camc314 commented Oct 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camc314 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-minifier Area - Minifier label Oct 10, 2024
@camc314 camc314 force-pushed the c/10-10-do_not_merge_perf_test branch from b877071 to fee1156 Compare October 10, 2024 15:20
@camc314 camc314 changed the title DO NOT MERGE: perf test DO NOT MERGE: perf regression test Oct 10, 2024
@camc314 camc314 closed this Oct 10, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 10, 2024

CodSpeed Performance Report

Merging #6425 will degrade performances by 12.93%

Comparing c/10-10-do_not_merge_perf_test (fee1156) with main (6a194f9)

Summary

❌ 3 regressions
✅ 26 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main c/10-10-do_not_merge_perf_test Change
minifier[antd.js] 349.6 ms 401.6 ms -12.93%
minifier[react.development.js] 2.5 ms 2.8 ms -10.75%
minifier[typescript.js] 452.4 ms 513.2 ms -11.86%

@Boshen Boshen deleted the c/10-10-do_not_merge_perf_test branch February 17, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants