feat(minifier): implement folding `charCodeAt` string fns #6475

camc314 · 2024-10-12T12:34:02Z

No description provided.

graphite-app · 2024-10-12T12:34:06Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

camc314 · 2024-10-12T12:34:15Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camc314 and the rest of your teammates on Graphite

codspeed-hq · 2024-10-12T12:45:12Z

CodSpeed Performance Report

Merging #6475 will not alter performance

_{Comparing c/10-11-feat_minifier_implement_folding_charcodeat_string_fns (e6a5a1b) with main (4348eae)}

Summary

✅ 30 untouched benchmarks

crates/oxc_minifier/src/ast_passes/peephole_replace_known_methods.rs

7086cmd

I don't have enough time these days, so if things ready, call @Boshen to review and merge.

crates/oxc_minifier/src/ast_passes/peephole_replace_known_methods.rs

Boshen · 2024-10-24T14:35:46Z

Merge activity

Oct 24, 10:35 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 24, 10:37 AM EDT: A user added this pull request to the Graphite merge queue.
Oct 24, 10:42 AM EDT: A user merged this pull request with the Graphite merge queue.

## [0.34.0] - 2024-10-26 - 4618aa2 transformer: [**BREAKING**] Rename `TransformerOptions::react` to `jsx` (#6888) (Boshen) - 90c786c regular_expression: [**BREAKING**] Support ES2025 Duplicated named capture groups (#6847) (leaysgur) - 67a7bde napi/parser: [**BREAKING**] Add typings to napi/parser (#6796) (ottomated) ### Features - 1145341 ast_tools: Output typescript to a separate package (#6755) (ottomated) - 4429754 ecmascript: Constant eval `null` to number (#6879) (Boshen) - fd57e00 ecmascript: Add abstract_relational_comparison to dce (#6846) (Boshen) - 8bcaf59 minifier: Late peeophole optimization (#6882) (Boshen) - 860cbca minifier: Implement folding simple arrow fns (#6875) (camc314) - c26020e minifier: Implement folding String.prototype.replaceAll (#6871) (camc314) - 50744f3 minifier: Implement folding String.prototype.replace (#6870) (camc314) - fccf82e minifier: Implement folding `substring` string fns (#6869) (camc314) - e6a5a1b minifier: Implement folding `charCodeAt` string fns (#6475) (camc314) - 0d0bb17 transformer: Complete the async-to-generator plugin (#6658) (Dunqing) - 419343b traverse: Implement `GetAddress` for `Ancestor` (#6877) (overlookmotel) ### Bug Fixes - a47c70e minifier: Fix remaining runtime bugs (#6855) (Boshen) - 686727f minifier: Reference read has side effect (#6851) (Boshen) - c658d93 minifier: Keep template literals with expressions (#6849) (Boshen) - 4dc5e51 transformer: Only run typescript plugin for typescript source (#6889) (Boshen) - 076f5c3 transformer/typescript: Retain ExportNamedDeclaration without specifiers and declaration (#6848) (Dunqing) - b075982 types: Change @oxc/types package name (#6874) (ottomated) ### Documentation - 6eeb0e6 ast: Mention typescript-eslint, field ordering and shape (#6863) (Boshen) - 99e3b32 napi: Remove JSON.parse from example (#6836) (ottomated) ### Refactor - adb5039 allocator: Add `impl GetAddress for Address` (#6891) (overlookmotel) - 3e7507f ast_tools: Reduce macro usage (#6895) (overlookmotel) - 423d54c rust: Remove the annoying `clippy::wildcard_imports` (#6860) (Boshen) - 2d95009 transformer: Implement `Debug` on `StatementInjector` internal types (#6886) (overlookmotel) - c383c34 transformer: Make `StatementInjectorStore` methods generic over `GetAddress` (#6885) (overlookmotel) - 1f29523 transformer: Rename ReactJsx to Jsx (#6883) (Boshen) - 333b758 transformer: `StatementInjectorStore` methods take `&Statement` as target (#6858) (overlookmotel) - c19996c transformer: Add `StatementInjectorStore::insert_many_before` method (#6857) (overlookmotel) - 7339dde transformer: `StatementInjectorStore::insert_many_after` take an iterator (#6856) (overlookmotel) - 4348eae transformer/typescript: Re-order visitor methods (#6864) (overlookmotel) - 3a56d59 transformer/typescript: Insert assignments after super by `StatementInjector` (#6654) (Dunqing) - a366fae traverse: Rename `TraverseScoping::generate_binding_in_current_scope` (#6832) (overlookmotel) - 3b99fe6 traverse: Move `generate_binding` to `TraverseScoping` (#6831) (overlookmotel) - 60f487a traverse: `TraverseCtx::generate_binding` take an `Atom` (#6830) (overlookmotel) ### Styling - 262b2ed ast: Move crate doc comment to top of file (#6890) (overlookmotel) --------- Co-authored-by: Boshen <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

…t#6475)

## [0.34.0] - 2024-10-26 - 4618aa2 transformer: [**BREAKING**] Rename `TransformerOptions::react` to `jsx` (oxc-project#6888) (Boshen) - 90c786c regular_expression: [**BREAKING**] Support ES2025 Duplicated named capture groups (oxc-project#6847) (leaysgur) - 67a7bde napi/parser: [**BREAKING**] Add typings to napi/parser (oxc-project#6796) (ottomated) ### Features - 1145341 ast_tools: Output typescript to a separate package (oxc-project#6755) (ottomated) - 4429754 ecmascript: Constant eval `null` to number (oxc-project#6879) (Boshen) - fd57e00 ecmascript: Add abstract_relational_comparison to dce (oxc-project#6846) (Boshen) - 8bcaf59 minifier: Late peeophole optimization (oxc-project#6882) (Boshen) - 860cbca minifier: Implement folding simple arrow fns (oxc-project#6875) (camc314) - c26020e minifier: Implement folding String.prototype.replaceAll (oxc-project#6871) (camc314) - 50744f3 minifier: Implement folding String.prototype.replace (oxc-project#6870) (camc314) - fccf82e minifier: Implement folding `substring` string fns (oxc-project#6869) (camc314) - e6a5a1b minifier: Implement folding `charCodeAt` string fns (oxc-project#6475) (camc314) - 0d0bb17 transformer: Complete the async-to-generator plugin (oxc-project#6658) (Dunqing) - 419343b traverse: Implement `GetAddress` for `Ancestor` (oxc-project#6877) (overlookmotel) ### Bug Fixes - a47c70e minifier: Fix remaining runtime bugs (oxc-project#6855) (Boshen) - 686727f minifier: Reference read has side effect (oxc-project#6851) (Boshen) - c658d93 minifier: Keep template literals with expressions (oxc-project#6849) (Boshen) - 4dc5e51 transformer: Only run typescript plugin for typescript source (oxc-project#6889) (Boshen) - 076f5c3 transformer/typescript: Retain ExportNamedDeclaration without specifiers and declaration (oxc-project#6848) (Dunqing) - b075982 types: Change @oxc/types package name (oxc-project#6874) (ottomated) ### Documentation - 6eeb0e6 ast: Mention typescript-eslint, field ordering and shape (oxc-project#6863) (Boshen) - 99e3b32 napi: Remove JSON.parse from example (oxc-project#6836) (ottomated) ### Refactor - adb5039 allocator: Add `impl GetAddress for Address` (oxc-project#6891) (overlookmotel) - 3e7507f ast_tools: Reduce macro usage (oxc-project#6895) (overlookmotel) - 423d54c rust: Remove the annoying `clippy::wildcard_imports` (oxc-project#6860) (Boshen) - 2d95009 transformer: Implement `Debug` on `StatementInjector` internal types (oxc-project#6886) (overlookmotel) - c383c34 transformer: Make `StatementInjectorStore` methods generic over `GetAddress` (oxc-project#6885) (overlookmotel) - 1f29523 transformer: Rename ReactJsx to Jsx (oxc-project#6883) (Boshen) - 333b758 transformer: `StatementInjectorStore` methods take `&Statement` as target (oxc-project#6858) (overlookmotel) - c19996c transformer: Add `StatementInjectorStore::insert_many_before` method (oxc-project#6857) (overlookmotel) - 7339dde transformer: `StatementInjectorStore::insert_many_after` take an iterator (oxc-project#6856) (overlookmotel) - 4348eae transformer/typescript: Re-order visitor methods (oxc-project#6864) (overlookmotel) - 3a56d59 transformer/typescript: Insert assignments after super by `StatementInjector` (oxc-project#6654) (Dunqing) - a366fae traverse: Rename `TraverseScoping::generate_binding_in_current_scope` (oxc-project#6832) (overlookmotel) - 3b99fe6 traverse: Move `generate_binding` to `TraverseScoping` (oxc-project#6831) (overlookmotel) - 60f487a traverse: `TraverseCtx::generate_binding` take an `Atom` (oxc-project#6830) (overlookmotel) ### Styling - 262b2ed ast: Move crate doc comment to top of file (oxc-project#6890) (overlookmotel) --------- Co-authored-by: Boshen <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

camc314 mentioned this pull request Oct 12, 2024

feat(minifier): implement folding indexOf and lastIndexOf string fns #6435

Merged

camc314 mentioned this pull request Oct 12, 2024

feat(minifier): implement folding charAt string fns #6436

Merged

github-actions bot added the A-minifier Area - Minifier label Oct 12, 2024

camc314 marked this pull request as ready for review October 12, 2024 12:34

camc314 requested review from 7086cmd and Boshen October 12, 2024 12:34

camc314 force-pushed the c/10-10-feat_minifier_implement_folding_charat_string_fns branch from 05a79d4 to 273f6f5 Compare October 12, 2024 12:36

camc314 force-pushed the c/10-11-feat_minifier_implement_folding_charcodeat_string_fns branch from 5124d0f to 561ec3d Compare October 12, 2024 12:36

DonIsaac reviewed Oct 12, 2024

View reviewed changes

crates/oxc_minifier/src/ast_passes/peephole_replace_known_methods.rs Show resolved Hide resolved

Boshen force-pushed the c/10-10-feat_minifier_implement_folding_charat_string_fns branch from 273f6f5 to 096e590 Compare October 13, 2024 06:41

Base automatically changed from c/10-10-feat_minifier_implement_folding_charat_string_fns to main October 13, 2024 06:46

Boshen force-pushed the c/10-11-feat_minifier_implement_folding_charcodeat_string_fns branch from 561ec3d to 7d686fc Compare October 13, 2024 06:46

7086cmd reviewed Oct 13, 2024

View reviewed changes

crates/oxc_minifier/src/ast_passes/peephole_replace_known_methods.rs Outdated Show resolved Hide resolved

Boshen self-assigned this Oct 17, 2024

camc314 force-pushed the c/10-11-feat_minifier_implement_folding_charcodeat_string_fns branch from 7d686fc to 0d0616a Compare October 24, 2024 14:22

github-actions bot added the C-enhancement Category - New feature or request label Oct 24, 2024

camc314 force-pushed the c/10-11-feat_minifier_implement_folding_charcodeat_string_fns branch from 0d0616a to 59432fb Compare October 24, 2024 14:33

camc314 requested a review from 7086cmd October 24, 2024 14:33

Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 24, 2024

feat(minifier): implement folding charCodeAt string fns (#6475)

e6a5a1b

Boshen force-pushed the c/10-11-feat_minifier_implement_folding_charcodeat_string_fns branch from 59432fb to e6a5a1b Compare October 24, 2024 14:37

graphite-app bot merged commit e6a5a1b into main Oct 24, 2024

graphite-app bot deleted the c/10-11-feat_minifier_implement_folding_charcodeat_string_fns branch October 24, 2024 14:42

oxc-bot mentioned this pull request Oct 26, 2024

release(crates): v0.34.0 #6908

Merged

Orenbek pushed a commit to Orenbek/oxc that referenced this pull request Oct 28, 2024

feat(minifier): implement folding charCodeAt string fns (oxc-projec…

021ce3a

…t#6475)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(minifier): implement folding `charCodeAt` string fns #6475

feat(minifier): implement folding `charCodeAt` string fns #6475

camc314 commented Oct 12, 2024

Uh oh!

graphite-app bot commented Oct 12, 2024

Uh oh!

camc314 commented Oct 12, 2024 •

edited

Loading

Uh oh!

codspeed-hq bot commented Oct 12, 2024 •

edited

Loading

Uh oh!

Uh oh!

7086cmd left a comment •

edited

Loading

Uh oh!

Uh oh!

Boshen commented Oct 24, 2024 •

edited by graphite-app bot

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

feat(minifier): implement folding charCodeAt string fns #6475

feat(minifier): implement folding charCodeAt string fns #6475

Conversation

camc314 commented Oct 12, 2024

Uh oh!

graphite-app bot commented Oct 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

camc314 commented Oct 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Oct 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #6475 will not alter performance

Summary

Uh oh!

Uh oh!

7086cmd left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Boshen commented Oct 24, 2024 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat(minifier): implement folding `charCodeAt` string fns #6475

feat(minifier): implement folding `charCodeAt` string fns #6475

camc314 commented Oct 12, 2024 •

edited

Loading

codspeed-hq bot commented Oct 12, 2024 •

edited

Loading

7086cmd left a comment •

edited

Loading

Boshen commented Oct 24, 2024 •

edited by graphite-app bot

Loading