Skip to content

refactor(codegen): rename vars in CodeBuffer #6493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Oct 13, 2024
Merged

refactor(codegen): rename vars in CodeBuffer #6493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor(codegen): rename vars in CodeBuffer (#6493) 
Pure refactor. Just rename vars.
  • Loading branch information
@overlookmotel
overlookmotel committed Oct 13, 2024
commit 84a51ee5765f90192af9055f0ee497d2f7b123c7
10 changes: 5 additions & 5 deletions crates/oxc_codegen/src/code_buffer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,11 +262,11 @@ impl CodeBuffer {
/// code.print_ascii([b'f', b'o', b'o'].into_iter());
/// assert_eq!(String::from(code), "foo");
/// ```
pub fn print_ascii<I>(&mut self, chars: I)
pub fn print_ascii<I>(&mut self, bytes: I)
where
I: IntoIterator<Item = u8>,
{
let iter = chars.into_iter();
let iter = bytes.into_iter();
let hint = iter.size_hint();
self.buf.reserve(hint.1.unwrap_or(hint.0));
for c in iter {
Expand Down Expand Up @@ -355,12 +355,12 @@ impl AsRef<[u8]> for CodeBuffer {

impl From<CodeBuffer> for String {
#[inline]
fn from(printer: CodeBuffer) -> Self {
fn from(buffer: CodeBuffer) -> Self {
if cfg!(debug_assertions) {
String::from_utf8(printer.buf).unwrap()
String::from_utf8(buffer.buf).unwrap()
} else {
// SAFETY: `buf` is valid UTF-8 because of invariants upheld by `CodeBuffer`
unsafe { String::from_utf8_unchecked(printer.buf) }
unsafe { String::from_utf8_unchecked(buffer.buf) }
}
}
}
Expand Down