Skip to content

fix(regular_expression): Fixed control Y regular expression #6524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 7 commits into from
Oct 14, 2024
Merged

fix(regular_expression): Fixed control Y regular expression #6524

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
27b1f14
fix(regular_expression): Fixed control Y regular expression
tapanprakasht Oct 13, 2024
5a4648c
Updated snapshot
tapanprakasht Oct 13, 2024
7380280
Fixed snapshot
tapanprakasht Oct 13, 2024
05383ee
Revert "Fixed snapshot"
tapanprakasht Oct 13, 2024
13e2902
Revert "Updated snapshot"
tapanprakasht Oct 13, 2024
814e4b1
Fixed snapshot
tapanprakasht Oct 13, 2024
fcb1ca6
Merge branch 'main' into fix-regular-expr-codegen
tapanprakasht Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(regular_expression): Fixed control Y regular expression
  • Loading branch information
@tapanprakasht
tapanprakasht committed Oct 13, 2024
commit 27b1f14558c22c7343188a03ea83cbf3a050621c
2 changes: 2 additions & 0 deletions crates/oxc_regular_expression/src/ast_impl/display.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,7 @@ fn character_to_string(
'\n' => r"\cJ".to_string(),
'\r' => r"\cM".to_string(),
'\t' => r"\cI".to_string(),
'\u{0019}' => r"\cY".to_string(),
_ => format!(r"\c{ch}"),
},
CharacterKind::Identifier => {
Expand Down Expand Up @@ -482,6 +483,7 @@ mod test {
(r"/\d/g", None),
("/abcd/igv", Some("/abcd/igv")),
(r"/\d/ug", Some(r"/\d/ug")),
(r"/\cY/", None),
// we capitalize hex unicodes.
(r"/\n\cM\0\x41\u{1f600}\./u", Some(r"/\n\cM\0\x41\u{1F600}\./u")),
(r"/\u02c1/u", Some(r"/\u02C1/u")),
Expand Down