perf(codegen): use AsciiChar for statically unknowable characters

[overlookmotel]

Small optimization. Use AsciiChar (introduced in #6537) for pushing bytes to buffer where the byte values are not statically known.

This also allows removing some unsafe code.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[overlookmotel]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• perf(codegen): use AsciiChar for statically unknowable characters #6538 👈
• feat(data_structures): introduce AsciiChar #6537
• refactor(codegen)!: Codegen::into_source_text consume Codegen #6539
• docs(codegen): fix example for CodeBuffer::print_ascii_bytes #6535
• perf(codegen): check last char with byte methods #6509
• perf(codegen): optimize CodeBuffer::print_ascii_byte #6516
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #6538 will not alter performance

_{Comparing 10-13-perf_codegen_use_asciichar_for_statically_unknowable_characters (21226b2) with 10-13-feat_data_structures_introduce_asciichar_ (50e6c68)}

Summary

✅ 29 untouched benchmarks

[overlookmotel]

Weird performance effects. I'll look into it.

[Boshen]

This is making the code way too complicated, can I reject?

[overlookmotel]

This is making the code way too complicated, can I reject?

Yes, I see your point. Too much complexity for not enough gain.