Skip to content

fix(no-unused-vars): consider functions within conditional expressions usable #6553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DonIsaac merged 4 commits into from
Oct 15, 2024
Merged

fix(no-unused-vars): consider functions within conditional expressions usable #6553

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1beb640
fix(no-unused-vars): consider functions within conditional expression…
eventualbuddha Oct 14, 2024
1b886b1
style(no-unused-vars): fix clippy lints
eventualbuddha Oct 14, 2024
a387d57
test(no-unused-vars): move to `oxc` from `eslint` suite
eventualbuddha Oct 14, 2024
17d8b67
Merge branch 'main' into fix/no-unused-vars/conditional-expression
DonIsaac Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style(no-unused-vars): fix clippy lints
  • Loading branch information
@eventualbuddha
eventualbuddha committed Oct 14, 2024
commit 1b886b1eb1875f93895e291f59827afd270175a0
10 changes: 4 additions & 6 deletions crates/oxc_linter/src/rules/eslint/no_unused_vars/allowed.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ impl<'s, 'a> Symbol<'s, 'a> {
| AstKind::ArrayExpressionElement(_)
| AstKind::ExpressionArrayElement(_)
| AstKind::ArrayExpression(_)
// a ? b : function foo() {}
// Only considered used if the function is the test or the selected branch,
// but we can't determine that here.
| AstKind::ConditionalExpression(_)
=> {
continue;
}
Expand Down Expand Up @@ -70,12 +74,6 @@ impl<'s, 'a> Symbol<'s, 'a> {
};
return body.span.contains_inclusive(self.span()) && body.statements.len() == 1 && !self.get_snippet(body.span).starts_with('{')
}
// a ? b : function foo() {}
// Only considered used if the function is the test or the selected branch,
// but we can't determine that here.
AstKind::ConditionalExpression(_) => {
continue;
}
_ => {
parent.kind().debug_name();
return false;
Expand Down