Skip to content

test(codegen): uncomment passed tests that are related to trailing comments #6589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Oct 15, 2024
Merged

test(codegen): uncomment passed tests that are related to trailing comments #6589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test(codegen): uncomment passed tests that are related to trailing co… 
…mments (#6589)

Just uncomment them and replace whitespace with `\t`
  • Loading branch information
@Dunqing
Dunqing committed Oct 15, 2024
commit e7c89a596b4e556a555b8c56da732f6cd021bde8
32 changes: 15 additions & 17 deletions crates/oxc_codegen/tests/integration/esbuild.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,10 @@ fn test_new() {
// test_minify("new x() ** 2", "new x**2;");

// Test preservation of Webpack-specific comments
// TODO: Not support trailing comments yet
// test(
// "new Worker(// webpackFoo: 1\n // webpackBar: 2\n 'path');",
// "new Worker(\n // webpackFoo: 1\n // webpackBar: 2\n \"path\"\n);\n",
// );
test(
"new Worker(// webpackFoo: 1\n // webpackBar: 2\n 'path');",
"new Worker(\n\t// webpackFoo: 1\n\t// webpackBar: 2\n\t\"path\"\n);\n",
);
test(
"new Worker(/* webpackFoo: 1 */ /* webpackBar: 2 */ 'path');",
"new Worker(\n\t/* webpackFoo: 1 */\n\t/* webpackBar: 2 */\n\t\"path\"\n);\n",
Expand Down Expand Up @@ -245,12 +244,12 @@ fn test_call() {
// testMangleMinify(t, "(1 ? eval : 2)?.(x)", "eval?.(x);");

// Webpack-specific comments
// TODO: Not support trailing comments yet
// test(
// "import(// webpackFoo: 1\n // webpackBar: 2\n 'path');",
// "import(\n // webpackFoo: 1\n // webpackBar: 2\n \"path\"\n);\n",
// );
// test( "import(// webpackFoo: 1\n // webpackBar: 2\n 'path', {type: 'module'});", "import(\n // webpackFoo: 1\n // webpackBar: 2\n \"path\",\n { type: \"module\" }\n);\n");
test(
"require(// webpackFoo: 1\n // webpackBar: 2\n 'path');",
"require(\n\t// webpackFoo: 1\n\t// webpackBar: 2\n\t\"path\"\n);\n",
);
test( "require(// webpackFoo: 1\n // webpackBar: 2\n 'path', {type: 'module'});",
"require(\n\t// webpackFoo: 1\n\t// webpackBar: 2\n\t\"path\",\n\t{ type: \"module\" }\n);\n");
test(
"require(/* webpackFoo: 1 */ /* webpackBar: 2 */ 'path');",
"require(\n\t/* webpackFoo: 1 */\n\t/* webpackBar: 2 */\n\t\"path\"\n);\n",
Expand Down Expand Up @@ -659,12 +658,11 @@ fn test_decorators() {
fn test_import() {
test("import('path');", "import(\"path\");\n"); // The semicolon must not be a separate statement

// TODO: Not support trailing comments yet
// test(
// "import(// webpackFoo: 1\n // webpackBar: 2\n 'path');",
// "import(\n // webpackFoo: 1\n // webpackBar: 2\n \"path\"\n);\n",
// );
// test( "import(// webpackFoo: 1\n // webpackBar: 2\n 'path', {type: 'module'});", "import(\n // webpackFoo: 1\n // webpackBar: 2\n \"path\",\n { type: \"module\" }\n);\n");
test(
"import(// webpackFoo: 1\n // webpackBar: 2\n 'path');",
"import(\n\t// webpackFoo: 1\n\t// webpackBar: 2\n\t\"path\"\n);\n",
);
test( "import(// webpackFoo: 1\n // webpackBar: 2\n 'path', {type: 'module'});", "import(\n\t// webpackFoo: 1\n\t// webpackBar: 2\n\t\"path\",\n\t{ type: \"module\" }\n);\n");
test(
"import(/* webpackFoo: 1 */ /* webpackBar: 2 */ 'path');",
"import(\n\t/* webpackFoo: 1 */\n\t/* webpackBar: 2 */\n\t\"path\"\n);\n",
Expand Down