Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Oct 18, 2024

close: #6641

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 18, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Dunqing commented Oct 18, 2024

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Oct 18, 2024
@Dunqing Dunqing changed the title feat(transformer): introduce StatementInjector helper feat(transformer): introduce StatementInjector helper Oct 18, 2024
@Dunqing Dunqing requested a review from overlookmotel October 18, 2024 07:22
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 18, 2024

CodSpeed Performance Report

Merging #6653 will not alter performance

Comparing 10-18-feat_transformer_introduce_statementinjector_helper (7fbca9d) with main (b2f3040)

Summary

✅ 30 untouched benchmarks

Copy link
Member

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed 3 commits with style nits / var name changes. I hope they're OK with you @Dunqing.

@overlookmotel overlookmotel force-pushed the 10-18-feat_ast_add_getaddress_trait branch from 98d0f5f to b2f3040 Compare October 21, 2024 10:45
Base automatically changed from 10-18-feat_ast_add_getaddress_trait to main October 21, 2024 10:50
@github-actions github-actions bot added the A-ast Area - AST label Oct 21, 2024
@overlookmotel overlookmotel force-pushed the 10-18-feat_transformer_introduce_statementinjector_helper branch from b170471 to 2270e72 Compare October 21, 2024 10:51
@Dunqing Dunqing marked this pull request as ready for review October 21, 2024 10:54
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024
Copy link
Member Author

Dunqing commented Oct 21, 2024

Merge activity

  • Oct 21, 6:54 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 21, 6:59 AM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 21, 7:04 AM EDT: A user merged this pull request with the Graphite merge queue.

@Dunqing Dunqing force-pushed the 10-18-feat_transformer_introduce_statementinjector_helper branch from b051f24 to 7fbca9d Compare October 21, 2024 11:00
@graphite-app graphite-app bot merged commit 7fbca9d into main Oct 21, 2024
@graphite-app graphite-app bot deleted the 10-18-feat_transformer_introduce_statementinjector_helper branch October 21, 2024 11:04
Dunqing added a commit that referenced this pull request Oct 21, 2024
Dunqing added a commit that referenced this pull request Oct 22, 2024
Dunqing added a commit that referenced this pull request Oct 22, 2024
Dunqing added a commit that referenced this pull request Oct 23, 2024
Dunqing added a commit that referenced this pull request Oct 23, 2024
Dunqing added a commit that referenced this pull request Oct 24, 2024
Dunqing added a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transformer: a helper for inserting new statements above or below the current statement.

3 participants