Skip to content

Conversation

@DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Oct 20, 2024

Change pub fn to pub(crate) fn for all internal methods in isolated declarations. I would appreciate someone who is more familiar with this code informing me if I incorrectly privatized methods that should be public.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-isolated-declarations Isolated Declarations C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 20, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite Graphite

@DonIsaac DonIsaac marked this pull request as ready for review October 20, 2024 23:46
@DonIsaac DonIsaac force-pushed the don/10-20-refactor_isolated-declarations_protect_internal_transform_methods branch from 4eb561e to 7ea18e7 Compare October 20, 2024 23:49
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 20, 2024

CodSpeed Performance Report

Merging #6723 will not alter performance

Comparing don/10-20-refactor_isolated-declarations_protect_internal_transform_methods (2e2b748) with main (f05a273)

Summary

✅ 30 untouched benchmarks

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Oct 21, 2024
Copy link
Member

Dunqing commented Oct 21, 2024

Merge activity

  • Oct 20, 9:58 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 20, 9:58 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 20, 10:07 PM EDT: A user merged this pull request with the Graphite merge queue.

Dunqing pushed a commit that referenced this pull request Oct 21, 2024
…6723)

Change `pub fn` to `pub(crate) fn` for all internal methods in isolated declarations. I would appreciate someone who is more familiar with this code informing me if I incorrectly privatized methods that should be public.
@Dunqing Dunqing force-pushed the don/10-20-refactor_isolated-declarations_protect_internal_transform_methods branch from 7ea18e7 to 4f0cba6 Compare October 21, 2024 01:59
…6723)

Change `pub fn` to `pub(crate) fn` for all internal methods in isolated declarations. I would appreciate someone who is more familiar with this code informing me if I incorrectly privatized methods that should be public.
@Dunqing Dunqing force-pushed the don/10-20-refactor_isolated-declarations_protect_internal_transform_methods branch from 4f0cba6 to 2e2b748 Compare October 21, 2024 02:03
@graphite-app graphite-app bot merged commit 2e2b748 into main Oct 21, 2024
@graphite-app graphite-app bot deleted the don/10-20-refactor_isolated-declarations_protect_internal_transform_methods branch October 21, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-isolated-declarations Isolated Declarations C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants