refactor(allocator): move GetAddress trait into oxc_allocator
#6738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
github-actions
bot
added
A-ast
CodSpeed Performance ReportMerging #6738 will not alter performanceComparing Summary
|
Member
Merge activity
|
Dunqing
force-pushed
the
10-21-refactor_transformer_rename_oxcvec_to_avec_
branch
from
a5d44f4 to
64bd821
Compare
Dunqing
force-pushed
the
10-21-refactor_allocator_move_getaddress_trait_into_oxc_allocator_
branch
from
953c9d2 to
f8d8258
Compare
Dunqing
force-pushed
the
10-21-refactor_transformer_rename_oxcvec_to_avec_
branch
from
64bd821 to
06e06e3
Compare
Dunqing
force-pushed
the
10-21-refactor_allocator_move_getaddress_trait_into_oxc_allocator_
branch
from
f8d8258 to
ab8aa2f
Compare
Base automatically changed from
10-21-refactor_transformer_rename_oxcvec_to_avec_
to
main
October 21, 2024 11:51
graphite-app
bot
deleted the
10-21-refactor_allocator_move_getaddress_trait_into_oxc_allocator_
branch
Boshen
pushed a commit
that referenced
this pull request
Oct 21, 2024
Follow-on after #6738. Since `GetAddress` is now defined in `oxc_allocator` crate, `impl GetAddress for Statement` doesn't need its own file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor. It makes more sense to me for
AddressandGetAddressto be defined in the same place. Also then we can use the trait forimpl GetAddress for Box.