Skip to content

Conversation

@shulaoda
Copy link
Member

@shulaoda shulaoda commented Oct 21, 2024

closes #6736

There may be a better solution. If there is a good way to fix it, please feel free to close it. I will fix the clippy problem later because I went back to the dormitory to sleep and my computer was in the studio.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@shulaoda shulaoda changed the title fix(linter): correct false positive in no-duplicates fix(linter): correct false positive in no-duplicates Oct 21, 2024
@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Oct 21, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 21, 2024

CodSpeed Performance Report

Merging #6748 will not alter performance

Comparing shulaoda:fix/linter-no-duplicates (29124bf) with main (9648e98)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen merged commit 54a5032 into oxc-project:main Oct 22, 2024
@shulaoda shulaoda deleted the fix/linter-no-duplicates branch October 22, 2024 05:37
@cheald
Copy link

cheald commented Oct 23, 2024

I just upgraded to oxlint 0.10.2 and this seems to have broken things for me, unless I misunderstand the rule. I have a huge number of reported breaks in my project now, like:

app/javascript/src/pages/Accounts/useAccountContext.tsx:1:39: Module '@apollo/client' is imported more than once in this file [Error]
app/javascript/src/pages/Accounts/useAccountContext.tsx:8:8: Modules should not be imported multiple times in the same file [Error]

My full import declaration for that file is:

import { QueryResult, useQuery } from "@apollo/client";
import {
  AccountRight,
  GetAccountDocument,
  GetAccountQuery,
  GetAccountQueryVariables,
  GrantRole,
} from "@app/graphql-codegen";
import { notEmpty } from "@app/utils";
import { Context } from "react";
import { useHistory } from "react-router-dom";

Downgrading to 0.10.0 (but not 0.10.1) causes the errors to disappear.

Boshen added a commit that referenced this pull request Oct 26, 2024
## [0.10.3] - 2024-10-26

- 90c786c regular_expression: [**BREAKING**] Support ES2025 Duplicated
named capture groups (#6847) (leaysgur)

- 8032813 regular_expression: [**BREAKING**] Migrate to new regexp
parser API (#6741) (leaysgur)

### Features

- a73c5af linter: Add fixer for `jsx-a11y/no-access-key` rule (#6781)
(Tapan Prakash)
- 2aa763c linter: Warn unmatched rule names (#6782) (Tapan Prakash)
- 0acca58 linter: Support `--print-config all` to print config file for
project (#6579) (mysteryven)

### Bug Fixes

- f49b3e2 linter: `react/iframe-missing-sandbox` ignores vanilla JS APIs
(#6872) (DonIsaac)
- 54a5032 linter: Correct false positive in `no-duplicates` (#6748)
(dalaoshu)
- a47c70e minifier: Fix remaining runtime bugs (#6855) (Boshen)

### Documentation

- 3923e63 linter: Add schema to config examples (#6838) (Dmitry
Zakharov)

### Refactor

- a148023 linter: Dereference IDs as soon as possible (#6821)
(overlookmotel)
- 423d54c rust: Remove the annoying `clippy::wildcard_imports` (#6860)
(Boshen)

---------

Co-authored-by: Boshen <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Orenbek pushed a commit to Orenbek/oxc that referenced this pull request Oct 28, 2024
## [0.10.3] - 2024-10-26

- 90c786c regular_expression: [**BREAKING**] Support ES2025 Duplicated
named capture groups (oxc-project#6847) (leaysgur)

- 8032813 regular_expression: [**BREAKING**] Migrate to new regexp
parser API (oxc-project#6741) (leaysgur)

### Features

- a73c5af linter: Add fixer for `jsx-a11y/no-access-key` rule (oxc-project#6781)
(Tapan Prakash)
- 2aa763c linter: Warn unmatched rule names (oxc-project#6782) (Tapan Prakash)
- 0acca58 linter: Support `--print-config all` to print config file for
project (oxc-project#6579) (mysteryven)

### Bug Fixes

- f49b3e2 linter: `react/iframe-missing-sandbox` ignores vanilla JS APIs
(oxc-project#6872) (DonIsaac)
- 54a5032 linter: Correct false positive in `no-duplicates` (oxc-project#6748)
(dalaoshu)
- a47c70e minifier: Fix remaining runtime bugs (oxc-project#6855) (Boshen)

### Documentation

- 3923e63 linter: Add schema to config examples (oxc-project#6838) (Dmitry
Zakharov)

### Refactor

- a148023 linter: Dereference IDs as soon as possible (oxc-project#6821)
(overlookmotel)
- 423d54c rust: Remove the annoying `clippy::wildcard_imports` (oxc-project#6860)
(Boshen)

---------

Co-authored-by: Boshen <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: import/no-duplicates false positive

5 participants