feat(traverse): add generate_binding and generate_binding_current_scope APIs in context

[Dunqing]

These two APIs are used to create a symbol with the provided symbol name, The difference from generate_uid is that we don't need to create a unique name for the symbol.

If you have a better method name for this, Feel free to edit this PR directly

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[Dunqing]

• refactor(transformer/typescript): use TraverseCtx::generate_binding to create a symbol #6806
• feat(traverse): add generate_binding and generate_binding_current_scope APIs in context #6805 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #6805 will not alter performance

_{Comparing 10-23-feat_traverse_add_generate_binding_and_generate_binding_current_scope_apis_in_context (c96e739) with main (22355f7)}

Summary

✅ 30 untouched benchmarks

[overlookmotel]

I think it'd be preferable if generate_binding took an Atom instead of a CompactStr. If it's an existing var name (which it must be, otherwise we'd be using generate_uid), an Atom will already exist in the arena for this symbol name, so we'd be better off reusing it. I'll submit that change in a follow-on PR.

This business with juggling CompactStrs and Atoms is a real pain!

[graphite-app]

Merge activity

• Oct 23, 11:44 AM EDT: A user added this pull request to the Graphite merge queue.
• Oct 23, 11:55 AM EDT: A user merged this pull request with the Graphite merge queue.