fix(linter): false positive in iframe-missing-sandbox

[shulaoda]

closes #6750

According to eslint-plugin-react, it seems that we should also search for // @jsx pragma in the source code.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[codspeed-hq]

CodSpeed Performance Report

Merging #6819 will not alter performance

_{Comparing shulaoda:fix/linter-iframe-missing-sandbox (1b2e891) with main (a148023)}

Summary

✅ 30 untouched benchmarks

[mysteryven]

There are also some false positive:

const createElement = document.createElement
createElement('iframe')

const React = myReact
React.createElement('iframe')

Can we port isDestructuredFromPragmaImport here? we can ignore the require part for this issue.

[shulaoda]

This might be a bit complicated, so let's focus on resolving the issue first, and we can improve the related code afterwards.

[mysteryven]

Or not add ctx.settings().react.pragma for this issue:

oxc/crates/oxc_linter/src/utils/react.rs

Line 147 in 6f22538

const PRAGMA: &str = "React";

[mysteryven]

Why not keep same with ESLint config file?

oxc/crates/oxc_linter/src/config/oxlintrc.rs

Line 16 in 3923e63

/// This configuration is aligned with ESLint v8's configuration schema (`eslintrc.json`).

[shulaoda]

I keep. Pragma is in settings.react.

[shulaoda]

form_components and link_components don't seem to be in react but we designed them this way from the beginning.

// <https://github.com/jsx-eslint/eslint-plugin-react#configuration-legacy-eslintrc->
#[derive(Debug, Clone, Deserialize, Serialize, JsonSchema)]
#[cfg_attr(test, derive(PartialEq))]
pub struct ReactPluginSettings {
    #[serde(default = "default_pragma")]
    pub pragma: CompactStr,

    #[serde(default)]
    #[serde(rename = "formComponents")]
    form_components: Vec<CustomComponent>,

    #[serde(default)]
    #[serde(rename = "linkComponents")]
    link_components: Vec<CustomComponent>,
    // TODO: More properties should be added
}

[shulaoda]

https://github.com/jsx-eslint/eslint-plugin-react#configuration-legacy-eslintrc

[mysteryven]

My fault, I missed this. Seems a simple way to fix this issue has merged.

[mysteryven]

Close in favor of #6872