feat(minifier): improve array expression handling in `remove_unused_expression` #9427

sapphi-red · 2025-02-28T04:59:44Z

No description provided.

sapphi-red · 2025-02-28T05:00:01Z

feat(minifier): support object expression in remove_unused_expression #9430 : 2 dependent PRs (#9431 , #9432 )
test(ecmascript): add comments and tests for cases where ToPropertyKey throws an error #9429
feat(minifier): improve array expression handling in remove_unused_expression #9427 👈 (View in Graphite)
feat(minifier): support template literals in remove_unused_expression #9426
fix(ecmascript): objects passed to template literals may have side effects #9425
refactor(minifier): use may_have_side_effects in remove_unused_expression #9413
feat(ecmascript): support /* @__PURE__ */ in may_have_side_effects #9409
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-02-28T05:12:22Z

CodSpeed Performance Report

Merging #9427 will not alter performance

_{Comparing 02-28-refactor_minifier_use_vec_drain_instead_of_iter_mut_move_ast_ (fb8a93d) with main (584d847)}

Summary

✅ 33 untouched benchmarks

graphite-app · 2025-02-28T07:49:04Z

Merge activity

Feb 28, 2:49 AM EST: A user added this pull request to the Graphite merge queue.
Feb 28, 2:58 AM EST: A user merged this pull request with the Graphite merge queue.

…xpression` (#9427)

## [0.54.0] - 2025-03-04 - 098f652 codegen: [**BREAKING**] Add `CommentAnnotation` to avoid parsing comments again (#9506) (Boshen) - a8d1d48 parser,codegen: [**BREAKING**] Parse and print`#__NO_SIDE_EFFECTS__` (#9496) (Boshen) - 355a4db napi/parser: [**BREAKING**] Remove `parse_without_return` API (#9455) (Boshen) - a5cde10 visit_ast: [**BREAKING**] Add `oxc_visit_ast` crate (#9428) (Boshen) - abb15e0 ast: [**BREAKING**] Add `pure` field to `Function`, `CallExpression`, and `NewExpression` (#9207) (overlookmotel) ### Features - a9f0d2b ast_tools: Generate field offset assertions for more types (#9449) (overlookmotel) - 64f4a82 ecmascript: Handle pure call expression in chain expressions (#9480) (sapphi-red) - 32139d2 ecmascript: Support `/* @__PURE__ */` in may_have_side_effects (#9409) (sapphi-red) - f5453f6 minifier: Flatten spread args in new expressions (#9512) (sapphi-red) - f8073f3 minifier: Support if with side effects in dead code elimination (#9502) (sapphi-red) - 10eb8f7 minifier: Use `remove_unused_expression` in `try_fold_sequence_expression` in `remove_dead_code` (#9467) (sapphi-red) - 70916db minifier: Remove unused expression in for init and update (#9466) (sapphi-red) - 26fde56 minifier: Inline simple IIFEs in `remove_unused_expression` (#9465) (sapphi-red) - ec2193e minifier: Support extracting arguments in pure calls in `remove_unused_expression` (#9463) (sapphi-red) - 007051c minifier: Compress `a != null && a.b()` to `a?.b()` in `remove_unused_expression` (#9459) (sapphi-red) - 50fce20 minifier: Support binary expression in `remove_unused_expression` (#9456) (sapphi-red) - ed9ede3 minifier: Support conditional expression in `remove_unused_expression` (#9432) (sapphi-red) - 3520538 minifier: Support object expression in `remove_unused_expression` (#9430) (sapphi-red) - fb8a93d minifier: Improve array expression handling in `remove_unused_expression` (#9427) (sapphi-red) - ff477cd minifier: Support template literals in `remove_unused_expression` (#9426) (sapphi-red) - 0d26113 minifier: Compress `/* @__PURE__ */ a() ? b : b` to `b` (#9410) (sapphi-red) - 68c77c8 napi/parser: Return semantic errors (#9460) (Boshen) - 7d7f16c parser: Apply pure to rhs of binary expression (#9492) (Boshen) - 2a08b14 parser: Support V8 intrinsics (#9379) (injuly) - 9b7017c parser,codegen: Pure annotations (#9351) (Boshen) - aa06932 transformer: Support `ModuleRunnerTransform` (#9371) (Dunqing) ### Bug Fixes - 75f06ad codegen: Do not print comments when only `annotation_comments` is enabled (#9518) (Dunqing) - f5bbd5d ecmascript: Fix toString for negative numbers (#9508) (sapphi-red) - d2cd975 ecmascript: Fix may_have_side_effects for `${a() === b}` (#9478) (sapphi-red) - 584d847 ecmascript: Objects passed to template literals may have side effects (#9425) (sapphi-red) - b371fdc estree/ast: Camel-case `typeAnnotation` field (#9420) (overlookmotel) - 1fff993 minifier: Correctly remove dead code in `try` with `finally` (#9503) (sapphi-red) - 0b96ebe minifier: Don't inline IIFE with parameters (#9477) (sapphi-red) - 071c84c minifier: Skip `try_fold_stmt_in_boolean_context` on `ExpressionStatement` (#9458) (sapphi-red) - 306284d minifier: Call mark_current_function_as_changed in remove_unused_expression (#9457) (sapphi-red) - 9c6ae9f parser: `@__NO_SIDE_EFFECTS` only affects const variable decl (#9517) (Boshen) - b7d5513 parser: Parse `@__NO_SIDE_EFFECTS__` between `export default` and `async function` (#9514) (Boshen) - 01de74c parser: Correctly fail parsing when parsing `foo.bar?.` (#9499) (camc314) - 58defe3 parser: Mark expression as pure in chain expression (#9479) (sapphi-red) - 2a03689 parser: Mark expressions on the left side of logical and conditional expressions as pure (#9414) (sapphi-red) - 7fde233 transformer/legacy-decorator: Incorrect check for potentially non-existent ident (#9491) (Dunqing) - b4f050c transformer/legacy-decorator: Metadata incorrectly wrapped by decorateParam (#9490) (Dunqing) - 5f67fa9 transformer/optional-chaning: Keep `this` when transforming `this.f?.()` (#9505) (camc314) ### Performance - 10e4431 ast/estree: Skip escaping identifiers (#9398) (overlookmotel) - b0a0a82 ast/estree: Reduce overhead serializing static strings (#9396) (overlookmotel) - 27a8e50 isolated_declarations: Reserve sufficient capacity in statements `Vec` (#9394) (overlookmotel) ### Refactor - 8916335 ast/estree: Convert enums with converters on variants (#9438) (overlookmotel) - dcff40c ast_tools: Generate layout assertions in multiple crates (#9448) (overlookmotel) - 19c4835 codegen: Simplify printing comments between arguments in call-like expressions (#9501) (Dunqing) - c880481 isolated_declarations: Rename var (#9390) (overlookmotel) - 37e41f0 isolated_declarations: Use aliases `ArenaBox` / `ArenaVec` (#9389) (overlookmotel) - bbb450c minifier: Move `a != null && b` -> `a ?? b` compression to `remove_unused_expression` (#9468) (sapphi-red) - b93774c minifier: Move `try_fold_iife` to `remove_unused_expression` (#9464) (sapphi-red) - 96a9719 minifier: Use `may_have_side_effects` in `remove_unused_expression` (#9413) (sapphi-red) ### Testing - c187b11 ecmascript: Add comments and tests for cases where `ToPropertyKey` throws an error (#9429) (sapphi-red) - d129055 napi: Add tests for worker threads (#9408) (Boshen) - 48d51e3 napi: Add tests for `hashbang` field (#9386) (overlookmotel) Co-authored-by: Boshen <[email protected]>

This was referenced Feb 28, 2025

feat(ecmascript): support /* @__PURE__ */ in may_have_side_effects #9409

Merged

refactor(minifier): use may_have_side_effects in remove_unused_expression #9413

Merged

This was referenced Feb 28, 2025

fix(ecmascript): objects passed to template literals may have side effects #9425

Merged

feat(minifier): support template literals in remove_unused_expression #9426

Merged

sapphi-red marked this pull request as ready for review February 28, 2025 05:00

github-actions bot added A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 28, 2025

sapphi-red marked this pull request as draft February 28, 2025 05:42

sapphi-red changed the base branch from 02-28-feat_minifier_support_template_literals_in_remove_unused_expression_ to graphite-base/9427 February 28, 2025 06:12

sapphi-red force-pushed the graphite-base/9427 branch from 25ba06f to 9cd0d1b Compare February 28, 2025 06:14

sapphi-red force-pushed the 02-28-refactor_minifier_use_vec_drain_instead_of_iter_mut_move_ast_ branch from a49c543 to 55d918e Compare February 28, 2025 06:14

sapphi-red changed the base branch from graphite-base/9427 to 02-28-feat_minifier_support_template_literals_in_remove_unused_expression_ February 28, 2025 06:14

sapphi-red changed the title ~~refactor(minifier): use Vec::drain instead of iter_mut + move_ast~~ feat(minifier): improve array expression handling in remove_unused_expression Feb 28, 2025

github-actions bot added the C-enhancement Category - New feature or request label Feb 28, 2025

sapphi-red removed the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Feb 28, 2025

sapphi-red marked this pull request as ready for review February 28, 2025 06:20

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 28, 2025

feat(minifier): improve array expression handling in `remove_unused_e…

fb8a93d

…xpression` (#9427)

graphite-app bot force-pushed the 02-28-feat_minifier_support_template_literals_in_remove_unused_expression_ branch from 9cd0d1b to ff477cd Compare February 28, 2025 07:49

graphite-app bot force-pushed the 02-28-refactor_minifier_use_vec_drain_instead_of_iter_mut_move_ast_ branch from 55d918e to fb8a93d Compare February 28, 2025 07:50

Base automatically changed from 02-28-feat_minifier_support_template_literals_in_remove_unused_expression_ to main February 28, 2025 07:54

graphite-app bot merged commit fb8a93d into main Feb 28, 2025
26 checks passed

graphite-app bot deleted the 02-28-refactor_minifier_use_vec_drain_instead_of_iter_mut_move_ast_ branch February 28, 2025 07:58

This was referenced Mar 3, 2025

release(crates): v0.54.0 #9494

Closed

release(crates): v0.54.0 #9524

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(minifier): improve array expression handling in `remove_unused_expression` #9427

feat(minifier): improve array expression handling in `remove_unused_expression` #9427

Uh oh!

sapphi-red commented Feb 28, 2025

Uh oh!

sapphi-red commented Feb 28, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Feb 28, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Feb 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

feat(minifier): improve array expression handling in remove_unused_expression #9427

feat(minifier): improve array expression handling in remove_unused_expression #9427

Uh oh!

Conversation

sapphi-red commented Feb 28, 2025

Uh oh!

sapphi-red commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #9427 will not alter performance

Summary

Uh oh!

graphite-app bot commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(minifier): improve array expression handling in `remove_unused_expression` #9427

feat(minifier): improve array expression handling in `remove_unused_expression` #9427

sapphi-red commented Feb 28, 2025 •

edited

Loading

codspeed-hq bot commented Feb 28, 2025 •

edited

Loading

graphite-app bot commented Feb 28, 2025 •

edited

Loading