feat(ast_tools): allow using #[ast] in NAPI packages
#9447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 28, 2025
Contributor
Merge activity
|
Previously `#[ast]` attr was only usable inside the `crates` directory. Extend that to also NAPI packages in the `napi` directory.
graphite-app
bot
force-pushed
the
02-28-feat_ast_tools_add_estree_no_flatten_attr_for_struct_fields
branch
from
e08b383 to
c959da2
Compare
graphite-app
bot
force-pushed
the
02-28-feat_ast_tools_allow_using_ast_in_napi_packages
branch
from
a33355f to
9afbae0
Compare
Base automatically changed from
02-28-feat_ast_tools_add_estree_no_flatten_attr_for_struct_fields
to
main
February 28, 2025 18:42
graphite-app
bot
deleted the
02-28-feat_ast_tools_allow_using_ast_in_napi_packages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
#[ast]attr was only usable inside thecratesdirectory. Extend that to also NAPI packages in thenapidirectory.