Skip to content

feat(ast/estree): export Node union type #9574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Mar 11, 2025
Merged

feat(ast/estree): export Node union type #9574

graphite-app merged 1 commit into from
Mar 11, 2025

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Mar 6, 2025 •
edited
Loading

@hi-ogawa Graphite App
Copy link
Contributor Author

hi-ogawa commented Mar 6, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast-tools Area - AST tools C-enhancement Category - New feature or request labels Mar 6, 2025
@hi-ogawa hi-ogawa marked this pull request as ready for review March 6, 2025 07:46
@hi-ogawa hi-ogawa requested a review from overlookmotel as a code owner March 6, 2025 07:46
overlookmotel
overlookmotel requested changes Mar 6, 2025
View reviewed changes
@hi-ogawa hi-ogawa force-pushed the 03-06-feat_ast_estree_export_node_union_type branch from 53fd96d to d669e6a Compare March 7, 2025 00:42
@hi-ogawa hi-ogawa changed the base branch from main to graphite-base/9574 March 7, 2025 00:53
@hi-ogawa hi-ogawa force-pushed the 03-06-feat_ast_estree_export_node_union_type branch from d669e6a to 51c0bfc Compare March 7, 2025 00:53
@hi-ogawa hi-ogawa changed the base branch from graphite-base/9574 to 03-07-refactor_ast_estree_remove_unused_custom_ts_def_ March 7, 2025 00:53
@hi-ogawa hi-ogawa mentioned this pull request Mar 7, 2025
Merged
@hi-ogawa hi-ogawa force-pushed the 03-06-feat_ast_estree_export_node_union_type branch from 51c0bfc to 56dbe20 Compare March 7, 2025 00:56
@hi-ogawa hi-ogawa force-pushed the 03-07-refactor_ast_estree_remove_unused_custom_ts_def_ branch from 1dd275b to e1baeb4 Compare March 7, 2025 00:56
@Boshen Boshen requested a review from overlookmotel March 10, 2025 14:24
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 11, 2025
@overlookmotel Graphite App
Copy link
Member

overlookmotel commented Mar 11, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Mar 11, 8:22 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 11, 8:22 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 11, 8:52 AM EDT: A user merged this pull request with the Graphite merge queue.

graphite-app bot pushed a commit that referenced this pull request Mar 11, 2025
@hi-ogawa
refactor(ast/estree): remove unused custom_ts_def (#9580)
1025b9f 
Following the suggestion #9574 (comment)
@graphite-app graphite-app bot force-pushed the 03-07-refactor_ast_estree_remove_unused_custom_ts_def_ branch from e1baeb4 to 1025b9f Compare March 11, 2025 12:43
@graphite-app graphite-app bot force-pushed the 03-06-feat_ast_estree_export_node_union_type branch from 56dbe20 to 446d11e Compare March 11, 2025 12:44
Base automatically changed from 03-07-refactor_ast_estree_remove_unused_custom_ts_def_ to main March 11, 2025 12:51
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 11, 2025
@graphite-app graphite-app bot merged commit 446d11e into main Mar 11, 2025
16 checks passed
@graphite-app graphite-app bot deleted the 03-06-feat_ast_estree_export_node_union_type branch March 11, 2025 12:52
@oxc-bot oxc-bot mentioned this pull request Mar 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel overlookmotel approved these changes

Assignees

@overlookmotel overlookmotel

Labels

A-ast-tools Area - AST tools C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@oxc-project/types to export a Node union type

3 participants

@hi-ogawa @overlookmotel