fix(ecmascript): (foo() + "").length may have a side effect
#9605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 8, 2025
Merged
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
sapphi-red
force-pushed
the
03-08-feat_minifier_compress_constant_integer_index_access
branch
from
77c64c2 to
a5ce548
Compare
sapphi-red
force-pushed
the
03-08-fix_ecmascript_foo_.length_may_have_a_side_effect
branch
from
331baa2 to
29d9d9d
Compare
CodSpeed Performance ReportMerging #9605 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
Member
Merge activity
|
`(foo() + "").length` may have a side effect because `foo()` may have a side effect.
graphite-app
bot
force-pushed
the
03-08-feat_minifier_compress_constant_integer_index_access
branch
from
a5ce548 to
554c4ce
Compare
graphite-app
bot
force-pushed
the
03-08-fix_ecmascript_foo_.length_may_have_a_side_effect
branch
from
29d9d9d to
96eef8b
Compare
Base automatically changed from
03-08-feat_minifier_compress_constant_integer_index_access
to
main
March 8, 2025 09:07
graphite-app
bot
deleted the
03-08-fix_ecmascript_foo_.length_may_have_a_side_effect
branch
Boshen
added a commit
that referenced
this pull request
Mar 11, 2025
## [0.57.0] - 2025-03-11 - 510446a parser: [**BREAKING**] Align JSXNamespacedName with ESTree (#9648) (Arnaud Barré) - b0d979d semantic: [**BREAKING**] Make `Scoping::references` private (#9629) (Boshen) - 3c6f140 semantic: [**BREAKING**] Make `Scoping` methods consistent (#9628) (Boshen) - ef6e0cc semantic: [**BREAKING**] Combine `SymbolTable` and `ScopeTree` into `Scoping` (#9615) (Boshen) - 7331656 semantic: [**BREAKING**] Rename `SymbolTable` and `ScopeTree` methods (#9613) (Boshen) - 23738bf semantic: [**BREAKING**] Introduce `Scoping` (#9611) (Boshen) ### Features - b6deff8 ecmascript: Support integer index access for array and string in `may_have_side_effects` (#9603) (sapphi-red) - 047fb01 minifier: Place `void 0` on right hand side if possible (#9606) (sapphi-red) - 36f8703 minifier: Compress `[] + string` to `string` (#9602) (sapphi-red) - 554c4ce minifier: Compress constant integer index access (#9604) (sapphi-red) - e3c2015 minifier: Allow compressing computed __proto__ more precisely (#9595) (sapphi-red) - 6a57198 minifier: Allow compressing computed constructor/prototype keys precisely (#9594) (sapphi-red) - 638007b parser: Apply `preserveParens` to `TSParenthesizedType` (#9653) (Boshen) ### Bug Fixes - eae1a41 ast: Align `TSImportType` field names with ts-eslint (#9664) (Boshen) - 96eef8b ecmascript: `(foo() + "").length` may have a side effect (#9605) (sapphi-red) - 24d9261 minifier: Remove names from functions / classes in normal pass to make the minifier idempotent (#9608) (sapphi-red) - 6ac3635 napi/parser: Disable raw transfer on unsupported platforms (#9651) (overlookmotel) - cfdcfdb parser: Fix end span for optional binding pattern without type annotation (#9652) (Boshen) - 26da65d parser: Parse asi after class accessor property (#9623) (Boshen) - 87462fd parser: Fix end span for `using` declaration (#9622) (Boshen) - 29edb51 transformer: Fix module runner transform of export default expression (#9661) (hi-ogawa) ### Documentation - 31a2618 allocator: Add safety constraint for `String::from_raw_parts_in` (#9640) (overlookmotel) ### Refactor - 44101bd allocator: Refactor and improve safty comments of `String::from_strs_array_in` (#9639) (overlookmotel) - c6edafe napi: Remove `npm/oxc-*/` npm packages (#9631) (Boshen) - a43c341 semantic: Add `Scoping` to `Semantic` (#9614) (Boshen) Co-authored-by: Boshen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(foo() + "").lengthmay have a side effect becausefoo()may have a side effect.