Skip to content

fix(linter): fix example lint declaration and macro syntax #9626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 1 commit into from
Mar 9, 2025
Merged

fix(linter): fix example lint declaration and macro syntax #9626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/oxc_linter/src/rules/eslint/no_obj_calls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ impl Default for NoObjCalls {
}
}

declare_oxc_lint! {
declare_oxc_lint!(
/// ### What it does
/// Disallow calling some global objects as functions
///
Expand Down Expand Up @@ -65,7 +65,7 @@ declare_oxc_lint! {
NoObjCalls,
eslint,
correctness,
}
);

fn is_global_obj(s: &str) -> bool {
NON_CALLABLE_GLOBALS.contains(&s)
Expand Down
4 changes: 2 additions & 2 deletions crates/oxc_linter/src/rules/jsx_a11y/aria_unsupported_elements.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ use crate::{
utils::{get_element_type, get_jsx_attribute_name},
};

declare_oxc_lint! {
declare_oxc_lint!(
/// ### What it does
///
/// Certain reserved DOM elements do not support ARIA roles, states and
Expand All @@ -36,7 +36,7 @@ declare_oxc_lint! {
jsx_a11y,
correctness,
fix
}
);

#[derive(Debug, Default, Clone)]
pub struct AriaUnsupportedElements;
Expand Down
6 changes: 3 additions & 3 deletions crates/oxc_macros/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ mod declare_oxc_lint;
/// #[derive(Debug, Default, Clone)]
/// pub struct NoDebugger;
///
/// declare_oxc_lint! {
/// declare_oxc_lint!(
/// /// ### What it does
/// ///
/// /// Checks for usage of the `debugger` statement
Expand All @@ -65,7 +65,6 @@ mod declare_oxc_lint;
/// /// `debugger` statements do not affect functionality when a debugger isn't attached.
/// /// They're most commonly an accidental debugging leftover.
/// ///
/// ///
/// /// ### Examples
/// ///
/// /// Examples of **incorrect** code for this rule:
Expand All @@ -81,9 +80,10 @@ mod declare_oxc_lint;
/// /// var debug = require('foo');
/// /// ```
/// NoDebugger,
/// eslint,
/// correctness,
/// fix
/// }
/// );
/// ```
#[proc_macro]
pub fn declare_oxc_lint(input: TokenStream) -> TokenStream {
Expand Down
Loading