Skip to content

feat(napi/parser): JSON.parse the returned AST in wasm #9630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Boshen merged 2 commits into from
Mar 18, 2025
Merged

feat(napi/parser): JSON.parse the returned AST in wasm #9630

Boshen merged 2 commits into from
Mar 18, 2025

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Mar 9, 2025

No description provided.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Mar 9, 2025
@Boshen Graphite App
Copy link
Member Author

Boshen commented Mar 9, 2025 •
edited by hi-ogawa
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen changed the title feat(napi/parser): JSON.parse the returned AST feat(napi/parser): JSON.parse the returned AST in wasm Mar 9, 2025
graphite-app bot pushed a commit that referenced this pull request Mar 9, 2025
@Boshen
feat(napi/parser): JSON.parse the returned AST in wasm (#9630)
0d2f001
@graphite-app graphite-app bot force-pushed the 03-09-feat_napi_parser_json.parse_the_returned_ast branch from c789a02 to 0d2f001 Compare March 9, 2025 13:33
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 9, 2025 •
edited
Loading

Merge activity

@Boshen Boshen marked this pull request as draft March 9, 2025 13:37
@Boshen Boshen mentioned this pull request Mar 14, 2025
Closed
@hi-ogawa hi-ogawa mentioned this pull request Mar 15, 2025
Merged
2 tasks
hi-ogawa
hi-ogawa reviewed Mar 15, 2025
View reviewed changes
hi-ogawa
hi-ogawa reviewed Mar 15, 2025
View reviewed changes
@hi-ogawa hi-ogawa force-pushed the 03-09-feat_napi_parser_json.parse_the_returned_ast branch from 0d2f001 to db3574b Compare March 15, 2025 09:29
@hi-ogawa
Copy link
Contributor

hi-ogawa commented Mar 15, 2025

I confirmed pnpm pack-ed packages from this PR works on Vite app. hi-ogawa/reproductions#49

@hi-ogawa
Copy link
Contributor

hi-ogawa commented Mar 16, 2025

Regarding oxc-project/playground#67, do you also consider using napi-rs instead of wasm-bind-gen for the entire @oxc/oxc_wasm package in playground?

@hi-ogawa hi-ogawa mentioned this pull request Mar 16, 2025
Closed
@Boshen Boshen force-pushed the 03-09-feat_napi_parser_json.parse_the_returned_ast branch from db3574b to 5bf345c Compare March 18, 2025 02:04
@Boshen Boshen marked this pull request as ready for review March 18, 2025 03:31
@Boshen Boshen merged commit 06518ae into main Mar 18, 2025
13 checks passed
@Boshen Boshen deleted the 03-09-feat_napi_parser_json.parse_the_returned_ast branch March 18, 2025 03:31
@oxc-bot oxc-bot mentioned this pull request Mar 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hi-ogawa hi-ogawa hi-ogawa left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Boshen @hi-ogawa