Skip to content

fix(linter): rule eslint/no-unsafe-optional-chaining #9632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camchenry merged 2 commits into from
Mar 10, 2025
Merged

fix(linter): rule eslint/no-unsafe-optional-chaining #9632

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e890783
Wip
therewillbecode Mar 9, 2025
8a28903
Handle spread element case in no unsafe opt chaining rule
therewillbecode Mar 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Wip
  • Loading branch information
@therewillbecode
therewillbecode committed Mar 9, 2025
commit e890783f7c8064cf93b9551e36429de006d76769
16 changes: 15 additions & 1 deletion crates/oxc_linter/src/rules/eslint/no_unsafe_optional_chaining.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use oxc_ast::{
AstKind,
ast::{Argument, AssignmentTarget, Expression, match_assignment_target_pattern},
ast::{Argument, ArrayExpressionElement, AssignmentTarget, Expression, match_assignment_target_pattern},
};
use oxc_diagnostics::OxcDiagnostic;
use oxc_macros::declare_oxc_lint;
Expand Down Expand Up @@ -164,6 +164,17 @@ impl NoUnsafeOptionalChaining {
Expression::AwaitExpression(expr) => {
Self::check_undefined_short_circuit(&expr.argument, error_type, ctx);
}
Expression::ExpressionStatement(expr) => {
let Expression::ArrayExpression(arr_expr) = expr.expression else {return;};
println!("aa {expr:?}");

for elem in arr_expr.elements.iter() {
if let ArrayExpressionElement::SpreadElement(spread_exp) = elem {
println!("foo {elem:?}");
Self::check_undefined_short_circuit(&spread_exp.argument, error_type, ctx);
}
}
}
Expression::ConditionalExpression(expr) => {
Self::check_undefined_short_circuit(&expr.consequent, error_type, ctx);
Self::check_undefined_short_circuit(&expr.alternate, error_type, ctx);
Expand Down Expand Up @@ -273,6 +284,9 @@ fn test() {
("with (obj?.foo) {};", None),
("async function foo() { with ( await obj?.foo) {}; }", None),
("(foo ? obj?.foo : obj?.bar).bar", None),
("const a = [...obj?.foo];", None),
// ("const b = [...c, ...obj?.foo];", None),
// ("const c = () => ([...(obj?.foo)]);", None),
];

Tester::new(NoUnsafeOptionalChaining::NAME, NoUnsafeOptionalChaining::PLUGIN, pass, fail)
Expand Down