feat(ast)!: Add raw property to JSXText node

[leaysgur]

I happened to find this while trying out https://github.com/leaysgur/prettier-plugin-oxc .

Acorn	OXC

Does it make sense to add?

[graphite-app]

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[codspeed-hq]

CodSpeed Performance Report

Merging #9641 will not alter performance

_{Comparing parser-jsx-text-raw (7de20bf) with main (f2b0cc1)}

Summary

✅ 33 untouched benchmarks

[leaysgur]

After some research, I finally conclude that this is not as simple as just adding a property.

I will write a summary as a topic later. => #9667

[overlookmotel]

I've re-opened as adding the raw field should be fairly simple. The huge performance hit is bizarre - this should be almost zero cost. I'll take a look and try to figure it out.

[overlookmotel]

• feat(ast)!: Add raw property to JSXText node #9641 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[overlookmotel]

Oh no actually the perf hit is not bizarre at all. It was only on the parser_napi_raw benchmarks (which we've now disabled, so it won't show up in updated benchmarks now that I've rebased this PR on main).

String decoding is the big bottle-neck in raw transfer - it's very very slow - and this introduces lots of large strings. That's nothing to worry about - I'm going to be working on fixing string decoding perf, and then this problem will go away.

[overlookmotel]

I've pushed 1 commit with a small fix. I think this is good to go now.

[leaysgur]

@overlookmotel Thank you for taking this over!

BTW, this code was just copied from parse_lietaral_string(), so the fixes might also be applicable to the original?

oxc/crates/oxc_parser/src/js/expression.rs

Line 401 in 7de20bf

Ok(self.ast.string_literal(self.end_span(span), value, Some(raw)))

[overlookmotel]

No thank you for your work on fixing the JS-side AST.

BTW, this code was just copied from parse_lietaral_string(), so the fixes might also be applicable to the original?

Thanks for pointing that out. #9737.