-
-
Notifications
You must be signed in to change notification settings - Fork 755
feat(allocator): add Vec2
#9646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #9646 will not alter performanceComparing Summary
Benchmarks breakdown
|
f328de5 to
7d8ee88
Compare
overlookmotel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I double-checked these 2 files are copied completely verbatim from bumpalo. Only differences are the addition of comments at top of files saying where the code was copied from, and running rustfmt on them.
Merging just this one for now. Would like to look into why lifetime changes are required in #9656 before merging the rest of the stack.
Merge activity
|
7d8ee88 to
3d4400c
Compare
Comment out methods which are feature-gated in `vec2::Vec` (the implementation copied from `bumpalo` in #9646).

related: #9706
These two files are copied from Bumplo's
vecandraw_vec, they will be used to replace allocator_api2'sVeclater PRs.