-
-
Notifications
You must be signed in to change notification settings - Fork 771
fix(parser)!: parse TS import attributes options as object expression #9662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
| /editors/vscode/out/ | ||
| /editors/vscode/*.vsix | ||
|
|
||
| # JetBrains |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 42 to 46 in 29edb51
| # NOTE: For non-project files such as `.vscode` or `.idea`, please add them to your `.gitignore_global`. | |
| # In `.gitconfig`, add `[core] excludesfile = ~/.gitignore_global` | |
| # See also | |
| # * https://stackoverflow.com/a/7335487 | |
| # * https://docs.github.com/en/get-started/getting-started-with-git/ignoring-files#configuring-ignored-files-for-all-repositories-on-your-computer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is that I don't want to ignore it on my repos
But I will use a local gitignore
|
Our AST is more strict and easier to work with, let's serialize this node as |
|
As it turns out |
|
I'll fix this. |
TS-ESLint spec: https://github.com/typescript-eslint/typescript-eslint/blob/9aa0b6b49807599b1c2b704b778df74c91084a7c/packages/ast-spec/src/type/TSImportType/spec.ts#L8
ast-explorer: https://ast-explorer.dev/#eNoty8EKQiEQheFXGc6q4PYCQoteotVsRIy8eB1xhiLEd0+p7XfO35HhsPuX19BSNWyoE+xT4w8uUXMqy8Pf6UZXSkeVZifGQ4SxUX8nezrq6+CIsasUxhjnGcoMOxeaHMPh77FpWuv6ZW9RjcFlYHwB6tsulA==
I'm block by the fact that
parse_object_expressionreturn an expression and not an objectExpressionFeel free to close another PR