Skip to content

Conversation

@ArnaudBarre
Copy link
Contributor

@ArnaudBarre ArnaudBarre commented Mar 11, 2025

@github-actions github-actions bot added A-parser Area - Parser A-ast Area - AST A-ast-tools Area - AST tools labels Mar 11, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 11, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the C-bug Category - Bug label Mar 11, 2025
/editors/vscode/out/
/editors/vscode/*.vsix

# JetBrains
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oxc/.gitignore

Lines 42 to 46 in 29edb51

# NOTE: For non-project files such as `.vscode` or `.idea`, please add them to your `.gitignore_global`.
# In `.gitconfig`, add `[core] excludesfile = ~/.gitignore_global`
# See also
# * https://stackoverflow.com/a/7335487
# * https://docs.github.com/en/get-started/getting-started-with-git/ignoring-files#configuring-ignored-files-for-all-repositories-on-your-computer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that I don't want to ignore it on my repos
But I will use a local gitignore

@Boshen Boshen self-assigned this Mar 11, 2025
@Boshen Boshen marked this pull request as draft March 11, 2025 03:13
@Boshen
Copy link
Member

Boshen commented Mar 11, 2025

Our AST is more strict and easier to work with, let's serialize this node as ObjectExpression instead. #9663

@Boshen
Copy link
Member

Boshen commented Mar 19, 2025

As it turns out import("foo", { with: { foo: "foo" } }) is an object expression 😅

@Boshen
Copy link
Member

Boshen commented Mar 19, 2025

I'll fix this.

Boshen added a commit that referenced this pull request Mar 20, 2025
@graphite-app graphite-app bot closed this in c631291 Mar 20, 2025
@ArnaudBarre ArnaudBarre deleted the ts-import-type-options branch May 4, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools A-parser Area - Parser C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants