Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 11, 2025

Follow-on after #9310. Pure refactor. Replace .into() calls with more explicit Expression::from etc. This syntax is longer, but personally I find it clearer. When I see .into(), I always find myself wondering "but into what?".

Copy link
Member Author

overlookmotel commented Mar 11, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 11, 2025
@overlookmotel overlookmotel marked this pull request as ready for review March 11, 2025 06:48
@overlookmotel overlookmotel requested a review from Dunqing as a code owner March 11, 2025 06:48
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 11, 2025

CodSpeed Performance Report

Merging #9675 will not alter performance

Comparing 03-11-refactor_transformer_using_remove_.into_ (076d872) with main (3ccb2fa)

Summary

✅ 39 untouched benchmarks

@camc314 camc314 force-pushed the 03-11-refactor_transformer_using_shorten_astbuilder_calls branch from ccde3da to fc25c3b Compare March 11, 2025 09:44
@camc314 camc314 force-pushed the 03-11-refactor_transformer_using_remove_.into_ branch from c1c03c8 to a4fed5a Compare March 11, 2025 09:44
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 11, 2025
@Boshen Boshen changed the base branch from 03-11-refactor_transformer_using_shorten_astbuilder_calls to graphite-base/9675 March 11, 2025 09:54
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 11, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Mar 11, 2025
Follow-on after #9310. Pure refactor. Replace `.into()` calls with more explicit `Expression::from` etc. This syntax is longer, but personally I find it clearer. When I see `.into()`, I always find myself wondering "but into *what*?".
@graphite-app graphite-app bot force-pushed the 03-11-refactor_transformer_using_remove_.into_ branch from a4fed5a to 786b7dc Compare March 11, 2025 10:15
@graphite-app graphite-app bot changed the base branch from graphite-base/9675 to 03-11-refactor_transformer_using_shorten_astbuilder_calls March 11, 2025 10:15
Base automatically changed from 03-11-refactor_transformer_using_shorten_astbuilder_calls to main March 11, 2025 10:26
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 11, 2025
graphite-app bot pushed a commit that referenced this pull request Mar 11, 2025
Follow-on after #9310. Pure refactor. Replace `.into()` calls with more explicit `Expression::from` etc. This syntax is longer, but personally I find it clearer. When I see `.into()`, I always find myself wondering "but into *what*?".
@graphite-app graphite-app bot force-pushed the 03-11-refactor_transformer_using_remove_.into_ branch from 786b7dc to 21859ca Compare March 11, 2025 10:42
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 11, 2025
Follow-on after #9310. Pure refactor. Replace `.into()` calls with more explicit `Expression::from` etc. This syntax is longer, but personally I find it clearer. When I see `.into()`, I always find myself wondering "but into *what*?".
@graphite-app graphite-app bot force-pushed the 03-11-refactor_transformer_using_remove_.into_ branch from 21859ca to 076d872 Compare March 11, 2025 12:12
@graphite-app graphite-app bot merged commit 076d872 into main Mar 11, 2025
32 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 11, 2025
@graphite-app graphite-app bot deleted the 03-11-refactor_transformer_using_remove_.into_ branch March 11, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants