-
-
Notifications
You must be signed in to change notification settings - Fork 755
feat(transformer/module_runner_transform): remove duplicate deps and dynamicDeps
#9709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transformer/module_runner_transform): remove duplicate deps and dynamicDeps
#9709
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
dpes and dynamicDepsdeps and dynamicDeps
hi-ogawa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like Vite dedupes using Set.add. Good catch!
CodSpeed Performance ReportMerging #9709 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
Merge activity
|
…d `dynamicDeps` (#9709) I found that the import source can be repeated, so it seems like removing the duplicate `deps` and `dynamicDeps` would be better, but I am not sure it is worth doing it.
d31b155 to
7f1a050
Compare
346d248 to
3429898
Compare

I found that the import source can be repeated, so it seems like removing the duplicate
depsanddynamicDepswould be better, but I am not sure it is worth doing it.