Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 12, 2025

I found that the import source can be repeated, so it seems like removing the duplicate deps and dynamicDeps would be better, but I am not sure it is worth doing it.

Copy link
Member Author

Dunqing commented Mar 12, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Mar 12, 2025
@Dunqing Dunqing requested review from hi-ogawa and sapphi-red and removed request for overlookmotel March 12, 2025 09:17
@Dunqing Dunqing changed the title feat(transformer/module_runner_transform): remove duplicate dpes and dynamicDeps feat(transformer/module_runner_transform): remove duplicate deps and dynamicDeps Mar 12, 2025
Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Vite dedupes using Set.add. Good catch!

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 12, 2025

CodSpeed Performance Report

Merging #9709 will create unknown performance changes

Comparing 03-12-feat_transformer_module_runner_transform_remove_duplicate_dpes_and_dynamicdeps (3429898) with main (325a1a4)

Summary

🆕 33 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 23.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 66.2 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.7 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 20.8 µs N/A
🆕 lexer[antd.js] N/A 24.1 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.7 ms N/A
🆕 lexer[checker.ts] N/A 14.5 ms N/A
🆕 lexer[pdf.mjs] N/A 3.8 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3 s N/A
🆕 mangler[antd.js] N/A 16.1 ms N/A
🆕 mangler[react.development.js] N/A 294.4 µs N/A
🆕 mangler[typescript.js] N/A 39.7 ms N/A
🆕 minifier[antd.js] N/A 167.6 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 294.5 ms N/A
🆕 estree[checker.ts] N/A 88.4 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 88.8 µs N/A
🆕 parser[antd.js] N/A 112.1 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Mar 12, 2025
Copy link
Member Author

Dunqing commented Mar 12, 2025

Merge activity

  • Mar 12, 5:26 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 12, 5:26 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 12, 5:37 AM EDT: A user merged this pull request with the Graphite merge queue.

…d `dynamicDeps` (#9709)

I found that the import source can be repeated, so it seems like removing the duplicate `deps` and `dynamicDeps` would be better, but I am not sure it is worth doing it.
@graphite-app graphite-app bot force-pushed the 03-12-test_transformer_module_runner_transform_add_more_tests_that_copy_from_vite branch from d31b155 to 7f1a050 Compare March 12, 2025 09:28
@graphite-app graphite-app bot force-pushed the 03-12-feat_transformer_module_runner_transform_remove_duplicate_dpes_and_dynamicdeps branch from 346d248 to 3429898 Compare March 12, 2025 09:29
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 12, 2025
Base automatically changed from 03-12-test_transformer_module_runner_transform_add_more_tests_that_copy_from_vite to main March 12, 2025 09:35
@graphite-app graphite-app bot merged commit 3429898 into main Mar 12, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 03-12-feat_transformer_module_runner_transform_remove_duplicate_dpes_and_dynamicdeps branch March 12, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants