Skip to content

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Mar 12, 2025

No description provided.

Copy link
Contributor Author

camc314 commented Mar 12, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor Author

@camc314 camc314 Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note, for this our output is the same, but:

  • our _usingCtx3 is babel's _usingCtx
  • our _usingCtx is babel's _usingCtx3

as we transform on exit, not on enter

@camc314 camc314 force-pushed the c/03-12-perf_transformer_using_only_transform_block_statements_if_needed branch from bf7c7d1 to 1a2e235 Compare March 12, 2025 12:22
@camc314 camc314 force-pushed the c/03-12-perf_transformer_using_only_do_work_to_a_switch_stmt_if_it_contains_a_using_decl branch from ac30c7d to f2b57bb Compare March 12, 2025 12:22
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 12, 2025

CodSpeed Performance Report

Merging #9716 will not alter performance

Comparing c/03-12-perf_transformer_using_only_transform_block_statements_if_needed (4cb9404) with c/03-12-perf_transformer_using_only_do_work_to_a_switch_stmt_if_it_contains_a_using_decl (f2b57bb)

Summary

✅ 33 untouched benchmarks

@camc314 camc314 force-pushed the c/03-12-perf_transformer_using_only_transform_block_statements_if_needed branch from 1a2e235 to 4cb9404 Compare March 12, 2025 12:27
@camc314
Copy link
Contributor Author

camc314 commented Mar 12, 2025

@overlookmotel the changes in this stack appear to regresss perf which is the opposite of what i intended 🫠 > #9717

@overlookmotel
Copy link
Member

the changes in this stack appear to regresss perf

Oh bollocks!

I'm tied up with some other stuff today. Will likely not get time to review until tomorrow. Maybe we can tweak it to get perf moving in the right direction.

@camc314 camc314 closed this Mar 18, 2025
@Boshen Boshen deleted the c/03-12-perf_transformer_using_only_transform_block_statements_if_needed branch August 30, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants