refactor(traverse): use ArenaBox alias
#9759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C-cleanup
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
changed the base branch from
03-13-refactor_traverse_add_traversectx_insert_scope_below_statements_
to
graphite-base/9759
CodSpeed Performance ReportMerging #9759 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
03-13-refactor_traverse_use_arenabox_alias
branch
from
0bd9410 to
ade8e8c
Compare
overlookmotel
force-pushed
the
graphite-base/9759
branch
from
acd9d10 to
bda4b9a
Compare
overlookmotel
force-pushed
the
03-13-refactor_traverse_use_arenabox_alias
branch
from
ade8e8c to
9b78faf
Compare
Member
Author
|
Just renaming, so merging without review. |
Member
Author
Merge activity
|
In transformer, and similar places, our convention is to import `oxc_allocator::Box` as `ArenaBox` and `oxc_allocator::Vec` as `ArenaVec` - to help distinguish between `std`'s `Box` / `Vec`, and their arena-allocated equivalents. Make that change in one place in `oxc_traverse`.
graphite-app
bot
force-pushed
the
03-13-refactor_traverse_use_arenabox_alias
branch
from
9b78faf to
1d60e85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In transformer, and similar places, our convention is to import
oxc_allocator::BoxasArenaBoxandoxc_allocator::VecasArenaVec- to help distinguish betweenstd'sBox/Vec, and their arena-allocated equivalents.Make that change in one place in
oxc_traverse.