Skip to content

perf(parser): pre-allocate enough space in ArrayExpression and ObjectExpressions conversion #9776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dunqing wants to merge 4 commits into from
Closed

perf(parser): pre-allocate enough space in ArrayExpression and ObjectExpressions conversion #9776

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4549f8
perf(parser): pre-allocate enough space in ArrayExpression and Object…
Dunqing Mar 14, 2025
a8b8160
Merge branch 'main' into 03-14-perf_parser_pre-allocate_enough_space_…
Dunqing Mar 14, 2025
d6e018e
try without preallocating
Dunqing Mar 14, 2025
f225ca4
Merge branch 'main' into 03-14-perf_parser_pre-allocate_enough_space_…
Dunqing Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
try without preallocating
  • Loading branch information
@Dunqing
Dunqing committed Mar 14, 2025
commit d6e018e6c8739857a40592034f0404900d60d5f5
4 changes: 2 additions & 2 deletions crates/oxc_parser/src/js/grammar.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ impl<'a> CoverGrammar<'a, Expression<'a>> for SimpleAssignmentTarget<'a> {
impl<'a> CoverGrammar<'a, ArrayExpression<'a>> for ArrayAssignmentTarget<'a> {
fn cover(expr: ArrayExpression<'a>, p: &mut ParserImpl<'a>) -> Result<Self> {
let len = expr.elements.len();
let mut elements = p.ast.vec_with_capacity(len);
let mut elements = p.ast.vec();
let mut rest = None;

for (i, elem) in expr.elements.into_iter().enumerate() {
Expand Down Expand Up @@ -120,7 +120,7 @@ impl<'a> CoverGrammar<'a, AssignmentExpression<'a>> for AssignmentTargetWithDefa
impl<'a> CoverGrammar<'a, ObjectExpression<'a>> for ObjectAssignmentTarget<'a> {
fn cover(expr: ObjectExpression<'a>, p: &mut ParserImpl<'a>) -> Result<Self> {
let len = expr.properties.len();
let mut properties = p.ast.vec_with_capacity(len);
let mut properties = p.ast.vec();
let mut rest = None;

for (i, elem) in expr.properties.into_iter().enumerate() {
Expand Down
Loading