Skip to content

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 18, 2025

See #9835. Add directive field to ExpressionStatement only in TS AST.

Copy link
Member Author

overlookmotel commented Mar 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Mar 18, 2025
@overlookmotel overlookmotel changed the title fix(ast/estree): add directive field to TS AST fix(ast/estree): add directive field to ExpressionStatement in TS AST Mar 18, 2025
@overlookmotel overlookmotel marked this pull request as ready for review March 18, 2025 04:47
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 18, 2025
Copy link
Member Author

overlookmotel commented Mar 18, 2025

Merge activity

  • Mar 18, 12:48 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 18, 12:57 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 18, 5:20 AM UTC: The Graphite merge queue couldn't merge this PR because it timed out.
  • Mar 18, 1:27 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 18, 1:27 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 18, 1:28 AM EDT: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from 03-18-feat_ast_tools_support_ts_attr_on_converter_meta_types to graphite-base/9844 March 18, 2025 04:53
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 18, 2025

CodSpeed Performance Report

Merging #9844 will not alter performance

Comparing 03-18-fix_ast_estree_add_directive_field_to_ts_ast (3f858c4) with main (3d17860)

Summary

✅ 33 untouched benchmarks

@graphite-app graphite-app bot changed the base branch from graphite-base/9844 to main March 18, 2025 05:00
@github-actions github-actions bot added the A-ast-tools Area - AST tools label Mar 18, 2025
graphite-app bot pushed a commit that referenced this pull request Mar 18, 2025
… AST (#9844)

See #9835. Add `directive` field to `ExpressionStatement` only in TS AST.
@graphite-app graphite-app bot force-pushed the 03-18-fix_ast_estree_add_directive_field_to_ts_ast branch from 7a70c80 to 1663c7e Compare March 18, 2025 05:01
graphite-app bot pushed a commit that referenced this pull request Mar 18, 2025
… AST (#9844)

See #9835. Add `directive` field to `ExpressionStatement` only in TS AST.
@graphite-app graphite-app bot force-pushed the 03-18-fix_ast_estree_add_directive_field_to_ts_ast branch from 1663c7e to 9676cb8 Compare March 18, 2025 05:03
graphite-app bot pushed a commit that referenced this pull request Mar 18, 2025
… AST (#9844)

See #9835. Add `directive` field to `ExpressionStatement` only in TS AST.
@graphite-app graphite-app bot force-pushed the 03-18-fix_ast_estree_add_directive_field_to_ts_ast branch from 9676cb8 to a6b84fc Compare March 18, 2025 05:10
… AST (#9844)

See #9835. Add `directive` field to `ExpressionStatement` only in TS AST.
@graphite-app graphite-app bot force-pushed the 03-18-fix_ast_estree_add_directive_field_to_ts_ast branch from a6b84fc to 3f858c4 Compare March 18, 2025 05:15
@overlookmotel
Copy link
Member Author

0.68% passing! 🎉🎉🎉

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 18, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 18, 2025
@graphite-app graphite-app bot merged commit 3f858c4 into main Mar 18, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 03-18-fix_ast_estree_add_directive_field_to_ts_ast branch March 18, 2025 05:28
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants