Skip to content

feat(mangler): collect symbols that is used to set name property #9897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
graphite-app merged 1 commit into from
Mar 23, 2025
Merged

feat(mangler): collect symbols that is used to set name property #9897

graphite-app merged 1 commit into from
Mar 23, 2025

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Mar 19, 2025 •
edited
Loading

Same as #9872 but implemented in the mangler instead.

close #9872

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Mar 19, 2025
@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Mar 19, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red mentioned this pull request Mar 19, 2025
Merged
@sapphi-red sapphi-red marked this pull request as ready for review March 19, 2025 13:53
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 19, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #9897 will not alter performance

Comparing 03-19-feat_mangler_collect_symbols_that_is_used_to_set_name_property (9992559) with main (89cb368)

Summary

✅ 33 untouched benchmarks

@Boshen Boshen self-requested a review March 20, 2025 09:22
@Boshen Boshen self-assigned this Mar 20, 2025
@Boshen Boshen force-pushed the 03-19-feat_mangler_collect_symbols_that_is_used_to_set_name_property branch from 95f70a0 to ecc446b Compare March 23, 2025 06:28
@sapphi-red
feat(mangler): collect symbols that is used to set name property (#…
9992559 
…9897)

Same as #9872 but implemented in the mangler instead.

close #9872
@graphite-app graphite-app bot force-pushed the 03-19-feat_mangler_collect_symbols_that_is_used_to_set_name_property branch from ecc446b to 9992559 Compare March 23, 2025 06:43
@graphite-app graphite-app bot merged commit 9992559 into main Mar 23, 2025
25 checks passed
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 23, 2025

Merge activity

@graphite-app graphite-app bot deleted the 03-19-feat_mangler_collect_symbols_that_is_used_to_set_name_property branch March 23, 2025 06:49
graphite-app bot pushed a commit that referenced this pull request Mar 23, 2025
@sapphi-red
feat(mangler): support keep_names option (#9898)
ea3de06 
Same with #9873, but built on top of #9897.

close #9873
close #9711
@oxc-bot oxc-bot mentioned this pull request Mar 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Boshen Boshen Awaiting requested review from Boshen

Assignees

@Boshen Boshen

Labels

C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sapphi-red @Boshen