Skip to content

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 20, 2025

We should always avoid calling .clone_in because it will lose scoping information and it is not an efficient way. clone_in will traverse ast and calling clone_in for its all fields recursively

@Dunqing Dunqing requested a review from overlookmotel as a code owner March 20, 2025 07:11
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 20, 2025
Copy link
Member Author

Dunqing commented Mar 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing changed the base branch from 03-20-refactor_mangler_minifier_initialize_a_vec_with_a_specific_value_using_vec_from_iter_in_combined_with_repeat_with to graphite-base/9916 March 20, 2025 07:15
@Dunqing Dunqing force-pushed the graphite-base/9916 branch from 662366f to e637e2e Compare March 20, 2025 07:15
@Dunqing Dunqing force-pushed the 03-20-refactor_transformer_construct_new_ast_instead_of_calling_clone_in_for_original_ast branch from 59365b9 to 78afc76 Compare March 20, 2025 07:15
@Dunqing Dunqing changed the base branch from graphite-base/9916 to main March 20, 2025 07:15
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 20, 2025

CodSpeed Instrumentation Performance Report

Merging #9916 will not alter performance

Comparing 03-20-refactor_transformer_construct_new_ast_instead_of_calling_clone_in_for_original_ast (7f06cec) with main (30990d2)

Summary

✅ 33 untouched benchmarks

@Dunqing Dunqing force-pushed the 03-20-refactor_transformer_construct_new_ast_instead_of_calling_clone_in_for_original_ast branch from 78afc76 to f240d0d Compare March 20, 2025 07:29
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 21, 2025
Copy link
Member

overlookmotel commented Mar 21, 2025

Merge activity

  • Mar 21, 4:36 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 21, 4:36 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 21, 4:43 AM EDT: A user merged this pull request with the Graphite merge queue.

…e_in()` (#9916)

We should always avoid calling `.clone_in` because it will lose scoping information and it is not an efficient way. `clone_in` will traverse ast and calling `clone_in` for its all fields recursively
@graphite-app graphite-app bot force-pushed the 03-20-refactor_transformer_construct_new_ast_instead_of_calling_clone_in_for_original_ast branch from fc34a09 to 7f06cec Compare March 21, 2025 08:37
@graphite-app graphite-app bot merged commit 7f06cec into main Mar 21, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 03-20-refactor_transformer_construct_new_ast_instead_of_calling_clone_in_for_original_ast branch March 21, 2025 08:43
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants