refactor(ast): replace AstBuilder::move_* methods with take
#9970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-parser
CodSpeed Instrumentation Performance ReportMerging #9970 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
overlookmotel
force-pushed
the
03-22-feat_allocator_takein_trait
branch
from
6711ae3 to
cd29674
Compare
overlookmotel
force-pushed
the
03-22-refactor_ast_replace_astbuilder_move__methods_with_take_
branch
from
1b55db0 to
0b7666d
Compare
overlookmotel
force-pushed
the
03-22-feat_allocator_takein_trait
branch
from
cd29674 to
d9b1775
Compare
overlookmotel
force-pushed
the
03-22-refactor_ast_replace_astbuilder_move__methods_with_take_
branch
2 times, most recently
from
db93324 to
bf9c9fb
Compare
overlookmotel
force-pushed
the
03-22-feat_allocator_takein_trait
branch
from
d9b1775 to
46d3858
Compare
overlookmotel
force-pushed
the
03-22-refactor_ast_replace_astbuilder_move__methods_with_take_
branch
from
bf9c9fb to
682d612
Compare
overlookmotel
deleted the
03-22-refactor_ast_replace_astbuilder_move__methods_with_take_
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 24, 2025
`AstBuilder::move_*` methods use `TakeIn::take_in` (added in #9969) to replace nodes with dummy nodes. `take_in` will always generate a dummy in whatever way minimizes the size and number of allocations required. It would be possible to replace all the `move_*` methods with a single `AstBuilder::take` method which is generic over `T: TakeIn` (#9970). But have opted not to do that, because it's useful to be able to see in calling code what type of node is being replaced. Some nodes are quite expensive to create a dummy for (e.g. `Declaration` and `Function` require allocating 56 bytes into arena, `ArrowFunctionExpression` allocates 128 bytes in 2 separate allocations), so it's useful to see where we're doing that, so we can try to replace them with cheaper operations e.g. replacing an `Expression` or `Statement` instead (only 8 bytes). We also want to avoid inadvertently adding further expensive `take_in` calls, which a blanket `AstBuilder::take` method would make it easy to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.