Skip to content

Conversation

@therewillbecode
Copy link
Contributor

@therewillbecode therewillbecode commented Mar 23, 2025

Make theextends field in TSInterfaceDeclaration serialize to [] instead of null for interface declarations when the field is empty.

"extends": null -> "extends": []

PR is part of ongoing work to align our AST's ESTree output with that of TS-ESLint's. Relates to #9705

@therewillbecode therewillbecode marked this pull request as draft March 23, 2025 23:20
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 23, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the A-ast Area - AST label Mar 23, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 23, 2025

CodSpeed Instrumentation Performance Report

Merging #9996 will not alter performance

Comparing therewillbecode:fix/interface-extends (282030a) with main (9df65b7)

Summary

✅ 33 untouched benchmarks

@therewillbecode therewillbecode changed the title Add custom serializer for extends field of TSInterfaceDeclaration fix(ast/estree): Add custom serializer for extends field of TSInterfaceDeclaration Mar 23, 2025
@github-actions github-actions bot added the C-bug Category - Bug label Mar 23, 2025
@therewillbecode therewillbecode marked this pull request as ready for review March 23, 2025 23:52
@hi-ogawa hi-ogawa merged commit c98d3f4 into oxc-project:main Mar 24, 2025
27 checks passed
@therewillbecode therewillbecode deleted the fix/interface-extends branch April 11, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants