Skip to content

Conversation

@tienvx
Copy link
Contributor

@tienvx tienvx commented Jan 3, 2023

This is 7th pull request in a series of "small" pull requests I split from #210

This pull request depend on #283, please review it first.

There are 2 modes in PhpPact\Standalone\Runner\ProcessRunner:

  • runBlocking
  • runNonBlocking

runNonBlocking is not used at all, so we can replace ProcessRunner by Symfony's Process to reduce custom code.

@tienvx tienvx force-pushed the offload-process branch 4 times, most recently from 39031c1 to 9f15728 Compare March 3, 2023 01:17
@tienvx tienvx force-pushed the offload-process branch 3 times, most recently from 5af2ee1 to 6c3fa0f Compare March 13, 2023 06:31
@tienvx tienvx force-pushed the offload-process branch from b5c3fb7 to 8b30579 Compare May 6, 2023 17:45
@tienvx tienvx force-pushed the offload-process branch from 8b30579 to 7af5679 Compare May 8, 2023 16:12
@tienvx tienvx force-pushed the offload-process branch from 7af5679 to 840f940 Compare May 9, 2023 05:32
@tienvx tienvx force-pushed the offload-process branch 3 times, most recently from f425f93 to d23599b Compare May 10, 2023 04:35
@tienvx tienvx force-pushed the offload-process branch from d23599b to 6d19fa8 Compare May 12, 2023 06:41
@YOU54F
Copy link
Member

YOU54F commented Jul 24, 2023

merged in #323

6d19fa8

@tienvx
Copy link
Contributor Author

tienvx commented Jul 25, 2023

Close as there will be a PR from ffi to master

@tienvx tienvx closed this Jul 25, 2023
@tienvx tienvx deleted the offload-process branch July 31, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants