Gotta go fast #316
Closed
Gotta go fast #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix config setters returning a interface which prevents chaining when static analysis tools are in use as the interfaces are only a subset of what the class can do. * Set defaults similar to MockServerEnvConfig for timeouts as these are typed but not set to a value by default, forcing you to set them to avoid an error.
Pact consumer tests are supposed to be like unit tests but mine were taking 2 seconds+ each, the majority of which was a php sleep() Lots of unnecessary sleeps were slowing down my api and message tests. * Allow SetHealthCheckRetrySec / PACT_MOCK_SERVER_HEALTH_CHECK_RETRY_SEC to be a float so it can be set to 0.1 instead of 1. * Use usleep instead of sleep so that the retry seconds can be a < 1 second. * Increase the total number of attempts so it still tries for ~10 seconds. * Remove sleeps when PactMessage which do not appear to be needed.
Member
|
This is great, thanks for all of these PR's @slt. I'm not qualified to review the PHP bits, so will wait for a maintainer - but just wanted to pass on my gratitude. |
Closed
YOU54F
requested changes
Jul 14, 2023
Member
YOU54F
left a comment
YOU54F
left a comment
There was a problem hiding this comment.
the linter is failing, I've noted a comment
| return $service->healthCheck(); | ||
| } catch (ConnectionException $e) { | ||
| \sleep($retrySec); | ||
| \usleep(round($retrySec * 1000000)); |
Member
There was a problem hiding this comment.
round returns a float and usleep expects an int
https://www.php.net/manual/en/function.round.php
https://www.php.net/manual/en/function.usleep.php
usleep(intval(round($retrySec * 1000000)));
Member
Member
|
complete in #322 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pact consumer tests are supposed to be like unit tests but mine were taking 2 seconds+ each, the majority of which was php sleep()
Allow SetHealthCheckRetrySec / PACT_MOCK_SERVER_HEALTH_CHECK_RETRY_SEC
to be a float so it can be set to 0.1 instead of 1.
Use usleep instead of sleep so that the retry seconds can be a < 1 second.
Increase the total number of attempts so it still tries for ~10 seconds.
Remove sleeps in PactMessage which do not appear to be needed.
Results in my environment
3 pact consumer tests
Before - 00:06.577s
After - 00:01.603s
32 pact message tests
Before - 00:55.202s
After - 00:21.900s