Skip to content
This repository was archived by the owner on Nov 14, 2024. It is now read-only.

Conversation

@qinfchen
Copy link

@qinfchen qinfchen commented Sep 5, 2018

Goals (and why):
pick the latest rebranded remoting

Implementation Description (bullets):
there are several changes made to http-remoting as part of the rebranding

  • http-remoting is renamed to conjure-java-runtime with the new group name com.palantir.conjure.java.runtime
  • http-remoting is renamed to conjure-java-runtime-api
  • http-remoting's tracing has been moved to tracing java with new group name com.palantir.tracing

Concerns (what feedback would you like?):

  • Need to work with atlasdb team to make the changes do not introduce potentially break and there is safe migration path for atlasdb to transition from remoting3 to conjure-java-runtime
  • tracing is thread local, renaming tracing potentially would break all projects' tracing, this is blocked on pick up rebranded remoting change tritium#100 to ensure that remoting3 and tracing use the same Tracer
  • if atlasdb throws remoting3 exceptions, atlasdb client needs to updated to handle both old and new exceptions.
  • remoting3 is already on jackson 2.9.5 but atlasdb is on jackson 2.6.7, and the new ObjectMappers require MapperFeature.ALLOW_COERCION_OF_SCALARS which is only available in 2.9.x

Where should we start reviewing?:
version.props

Priority (whenever / two weeks / yesterday):
two weeks


This change is Reviewable

@sandorw
Copy link
Contributor

sandorw commented Oct 3, 2018

Let's revisit this next week with infra people in town.

@qinfchen
Copy link
Author

qinfchen commented Oct 3, 2018

Makes sense. This pr is also pretty out of date

@sandorw sandorw closed this Dec 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants