Skip to content

Fixes #250 'Throwables other than Exceptions are not propagated to the main thread ' #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jannis-baratheon wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes #250 'Throwables other than Exceptions are not propagated to the main thread ' #252

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
281bf57
Upgraded Awaitility to 3.1.2. Fixes #250
jannis-baratheon Sep 21, 2018
fea591b
Added tests for #250
jannis-baratheon Sep 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added tests for #250
  • Loading branch information
@jannis-baratheon
jannis-baratheon committed Sep 21, 2018
commit fea591b2e65d77a72eb0c67a9948e09070834356
28 changes: 28 additions & 0 deletions ...-core/src/test/java/com/palantir/docker/compose/connection/waiting/ClusterWaitShould.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,32 @@ public class ClusterWaitShould {

wait.waitUntilReady(cluster);
}

@SuppressWarnings("unchecked")
@Test public void
should_propagate_throwable() throws InterruptedException {
class AThrowable extends Throwable {}

when(clusterHealthCheck.isClusterHealthy(cluster))
.thenThrow(AThrowable.class);

exception.expect(AThrowable.class);

ClusterWait wait = new ClusterWait(clusterHealthCheck, DURATION);
wait.waitUntilReady(cluster);
}

@SuppressWarnings("unchecked")
@Test public void
should_propagate_error() throws InterruptedException {
class AnError extends Error {}

when(clusterHealthCheck.isClusterHealthy(cluster))
.thenThrow(AnError.class);

exception.expect(AnError.class);

ClusterWait wait = new ClusterWait(clusterHealthCheck, DURATION);
wait.waitUntilReady(cluster);
}
}