-
Notifications
You must be signed in to change notification settings - Fork 89
always copy logs to circle in finally #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pnepywoda
wants to merge
8
commits into
master
Choose a base branch
from
pnepywoda/alwaysAfter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b3fd0b4
doesnt work - jupiter always calls after anyway
pnepywoda 5405420
mockito test
pnepywoda 00a42e7
remove integration tests
pnepywoda c2ce746
checkstyle
pnepywoda e070178
Add generated changelog entries
pnepywoda 9b0dac4
Update pr-384.v2.yml
pnepywoda e619465
no integration test
pnepywoda 3d98783
only-call-after-once check in DockerComposeManager
pnepywoda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
mockito test
- Loading branch information
commit 5405420f8e5afb280273a18dd62b857a128a2c39
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
...e-junit-jupiter/src/test/java/com/palantir/docker/compose/DockerComposeExtensionTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /* | ||
| * (c) Copyright 2019 Palantir Technologies Inc. All rights reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.palantir.docker.compose; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
|
|
||
| import com.palantir.docker.compose.configuration.DockerComposeFiles; | ||
| import com.palantir.docker.compose.connection.waiting.ClusterWait; | ||
| import com.palantir.docker.compose.events.EventConsumer; | ||
| import java.io.IOException; | ||
| import java.util.List; | ||
| import java.util.concurrent.atomic.AtomicInteger; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.extension.ExtensionContext; | ||
| import org.mockito.Mockito; | ||
|
|
||
| public class DockerComposeExtensionTest { | ||
|
|
||
| @Test | ||
| public void calls_after_only_once() throws IOException, InterruptedException { | ||
| AtomicInteger count = new AtomicInteger(); | ||
| DockerComposeExtension dockerComposeExtension = new DockerComposeExtension() { | ||
|
|
||
| @Override | ||
| public void before() { | ||
| throw new IllegalStateException("some error"); | ||
| } | ||
|
|
||
| @Override | ||
| public void after() { | ||
| count.incrementAndGet(); | ||
| } | ||
|
|
||
| @Override | ||
| public DockerComposeFiles files() { | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| protected List<ClusterWait> clusterWaits() { | ||
| return null; | ||
| } | ||
|
|
||
| @Override | ||
| protected List<EventConsumer> eventConsumers() { | ||
| return null; | ||
| } | ||
| }; | ||
|
|
||
| ExtensionContext extensionContext = Mockito.mock(ExtensionContext.class); | ||
| assertThatThrownBy(() -> dockerComposeExtension.beforeAll(extensionContext)) | ||
| .isInstanceOf(IllegalStateException.class); | ||
| dockerComposeExtension.afterAll(extensionContext); | ||
| assertThat(count.get()).isEqualTo(1); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should live in
DockerComposeManager, notDockerComposeExtensionthat wayDockerComposeRulegets this behaviour too.