Skip to content

Conversation

@andygrunwald
Copy link
Contributor

This PR upgrades the lib github.com/google/go-github from v33 to v35.

Somewhere, there is also an indirect use of github.com/google/go-github/v29.
I wasn't able to find it.

@bluekeyes
Copy link
Contributor

Thanks for this update. I try to stay on top of these, but fell a bit behind because go-github/v33 made some changes that broke compatibility with GitHub Enterprise 2.22, so we're still using go-github/v32 and go-githubapp 0.5.1 for many of our applications.

The go-github/v29 dependency comes from github.com/bradleyfalzon/ghinstallation. While annoying to have both versions, the v29 client is only used internally, so it doesn't impact users of the library.

@bluekeyes bluekeyes merged commit e1bd32a into palantir:develop Apr 27, 2021
@andygrunwald
Copy link
Contributor Author

Thanks @bluekeyes.
Would you be able to make a new release for others that use this lib outside of palantir?

PS: I made a PR in bradleyfalzon/ghinstallation to upgrade this as well: bradleyfalzon/ghinstallation#49

@bluekeyes
Copy link
Contributor

@andygrunwald
Copy link
Contributor Author

Thanks a lot @bluekeyes

@andygrunwald
Copy link
Contributor Author

FYI: I raised the follow up PR #83 to close the full update circle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants