fix #1161: Add error prone LoggerEnclosingClass #1163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loggers created using getLogger(Class<?>) must reference their enclosing class.
Generate changelog in
|
ferozco
reviewed
Jan 10, 2020
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/LoggerEnclosingClass.java
Outdated
Show resolved
Hide resolved
Contributor
|
CI failure is unrelated, looks like |
Contributor
Author
|
Removing the dead link here: #1164 |
Contributor
Author
|
Thanks for the quick review :-) |
Collaborator
|
Released 2.49.0 |
This was referenced Jan 10, 2020
This was referenced Jan 11, 2020
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loggers created using getLogger(Class<?>) must reference their enclosing
class.
Before this PR
After this PR
==COMMIT_MSG==
Add error prone LoggerEnclosingClass check. Loggers created using getLogger(Class<?>) must reference their enclosing class.
==COMMIT_MSG==
Possible downsides?
It's possible there are unexpected usage patterns which may need to be suppressed.