[improvement] Resolves deprecation warning for use of DefaultTask.newInputFile() #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves deprecation warning for use of DefaultTask.newInputFile().
The DefaultTask.newInputFile() method has been deprecated.
This is scheduled to be removed in Gradle 6.0.
Please use the ObjectFactory.fileProperty() method instead.
2 usages
CheckBomConflictTask.java:45
CheckNoUnusedPinTask.java:45
schlosna
added a commit
to schlosna/gradle-baseline
that referenced
this pull request
Jan 2, 2019
PR palantir#493 [build failed](https://circleci.com/gh/palantir/gradle-baseline/1913) due to bit rot for no longer valid link https://blog.fogcreek.com/effective-code-reviews-9-tips-from-a-converted-skeptic/ as FogCreek was acquired by Glitch and the old FogCreek blog now 404s. This PR updates the link to point at the [wayback machine version from early 2018](https://web.archive.org/web/20180313140443/https://blog.fogcreek.com/effective-code-reviews-9-tips-from-a-converted-skeptic/), though https://www.fogbugz.com/blog/9-effective-code-review-tips/ appears to be a similar, shortened version from FogBugz (former part of FogCreek). ``` ERROR https://blog.fogcreek.com/effective-code-reviews-9-tips-from-a-converted-skeptic/ X509: certificate is valid for *.wpengine.com, wpengine.com, not blog.fogcreek.com ```
Contributor
Author
|
See #494 for bit rot build fix |
bulldozer-bot bot
pushed a commit
that referenced
this pull request
Jan 7, 2019
<!-- PR title should start with '[fix]', '[improvement]' or '[break]' if this PR would cause a patch, minor or major SemVer bump. Omit the prefix if this PR doesn't warrant a standalone release. --> ## Before this PR <!-- Describe the problem you encountered with the current state of the world (or link to an issue) and why it's important to fix now. --> PR #493 [build failed](https://circleci.com/gh/palantir/gradle-baseline/1913) due to bit rot for no longer valid link https://blog.fogcreek.com/effective-code-reviews-9-tips-from-a-converted-skeptic/ as [Fog Creek was acquired by Glitch](https://glitch.com/about/fog-creek-is-now-glitch/) and the [old Fog Creek blog now 404s](https://blog.fogcreek.com). ``` ERROR https://blog.fogcreek.com/effective-code-reviews-9-tips-from-a-converted-skeptic/ X509: certificate is valid for *.wpengine.com, wpengine.com, not blog.fogcreek.com ``` ## After this PR <!-- Describe at a high-level why this approach is better. --> <!-- Reference any existing GitHub issues, e.g. 'fixes #000' or 'relevant to #000' --> This PR updates the link to point at https://www.fogbugz.com/blog/9-effective-code-review-tips/ from FogBugz (formerly part of FogCreek) that appears to be a shortened, similar version to the original ([recent version of the original page from the wayback machine](https://web.archive.org/web/20180814225126/https://blog.fogcreek.com/effective-code-reviews-9-tips-from-a-converted-skeptic/))
Contributor
|
👍 |
Contributor
|
Just an FYI that this adds gradle 5.0 minimum version. Probably should update the readme after this merges |
Contributor
|
I'd prefer to present this as a '[break]' actually and update the README as part of the same PR, as our minimum gradle version is only real user commitment! |
Contributor
|
Might as well leave this until we have reasonable coverage of Gradle 5 internally? So this doesn't block the rollout train? |
|
hey @iamdanfox @j-baker this is currently blocking an improvement to gradle-conjure: palantir/gradle-conjure#116 What's the update on the Gradle 5 internal coverage? Any chance that could be prioritized? |
Contributor
|
Honestly I think it would be simpler to just stop using RegularFileProperty and just use a Property, as we already say baseline requires at least Gradle 4.10.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
After this PR
Use non-deprecated file property factory method to avoid breakage when gradle 6.0 comes out.
See tritium build scan flagging deprecation: https://scans.gradle.com/s/pflkoibzlelue/deprecations#deprecation-0