[fix] Avoid lambda to allow build caching of checkstyle results #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is this only on gradle 5.1+ as well? |
Contributor
Author
|
probably? it's the same issue -- and we're on 5.2.1 |
Contributor
|
👍 As a long-term solution (and hopefully to prevent regressions on this), I started writing some gradle plugin specific error-prone rules here: https://github.com/iamdanfox/gradle-clippy. Seems like actually passing a lambda do a doLast is a much more obviously wrong thing that the other lints I already had! |
iamdanfox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Caching checkstyle results isn't possible due to same issue as in palantir/gradle-conjure#116
I can share an internal build scan pointing to this as the culprit.
After this PR
Caching checkstyleMain results should be possible.