Skip to content

Don't cache test tasks #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bulldozer-bot merged 4 commits into from
Jul 16, 2019
Merged

Don't cache test tasks #694

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
84f0d90
Don't cache test tasks
dansanduleac Jul 16, 2019
544a3cf
consolidate
dansanduleac Jul 16, 2019
b04b7f1
property
dansanduleac Jul 16, 2019
5429074
changelog
dansanduleac Jul 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineTesting.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ public void apply(Project project) {
.findAny()
.ifPresent(ignored -> enableJUnit5ForAllTestTasks(project));
});

// Never cache test tasks, until we work out the correct inputs for ETE / integration tests
project.getTasks().withType(Test.class).configureEach(test -> test.getOutputs().cacheIf(task -> false));
Copy link
Contributor

@ferozco ferozco Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some requests internally to allow users to opt out of this behaviour. We could expose a property that allows people to toggle ti

Copy link
Contributor Author

@dansanduleac dansanduleac Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

com.palantir.baseline.restore-test-cache = true ?

});
}

Expand Down