Skip to content

Promote safe logging checks from SUGGESTION -> WARNING #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamdanfox merged 2 commits into from
Jul 22, 2019
Merged

Promote safe logging checks from SUGGESTION -> WARNING #704

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eed4613
Change safe logging checks severity to WARNING
pkoenig10 Jul 18, 2019
f141155
Changelog
pkoenig10 Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Change safe logging checks severity to WARNING
  • Loading branch information
@pkoenig10
pkoenig10 committed Jul 18, 2019
commit eed4613138e2e0c9484f0eefde16a8586c5b1df8
2 changes: 1 addition & 1 deletion ...or-prone/src/main/java/com/palantir/baseline/errorprone/PreferSafeLoggableExceptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
name = "PreferSafeLoggableExceptions",
link = "https://github.com/palantir/gradle-baseline#baseline-error-prone-checks",
linkType = BugPattern.LinkType.CUSTOM,
severity = BugPattern.SeverityLevel.SUGGESTION,
severity = BugPattern.SeverityLevel.WARNING,
summary = "Throw SafeLoggable exceptions to ensure the exception message will not be redacted")
public final class PreferSafeLoggableExceptions extends BugChecker implements BugChecker.NewClassTreeMatcher {

Expand Down
2 changes: 1 addition & 1 deletion ...-prone/src/main/java/com/palantir/baseline/errorprone/PreferSafeLoggingPreconditions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
name = "PreferSafeLoggingPreconditions",
link = "https://github.com/palantir/gradle-baseline#baseline-error-prone-checks",
linkType = BugPattern.LinkType.CUSTOM,
severity = BugPattern.SeverityLevel.SUGGESTION,
severity = BugPattern.SeverityLevel.WARNING,
summary = "Precondition and similar checks with a constant message and no parameters should use equivalent "
+ "checks from com.palantir.logsafe.Preconditions for standardization as functionality is the same.")
public final class PreferSafeLoggingPreconditions extends BugChecker implements BugChecker.MethodInvocationTreeMatcher {
Expand Down