Skip to content

IntelliJ GitHub issue navigation #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bulldozer-bot merged 5 commits into from
Aug 2, 2019
Merged

IntelliJ GitHub issue navigation #729

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6370ab1
IntelliJ GitHub issue navigation
gatesn Aug 2, 2019
24c16a4
Fix tests to not use project
gatesn Aug 2, 2019
b340d19
Revert test
gatesn Aug 2, 2019
dd20179
Merge branch 'develop' into ngates/intellij-github-issues
gatesn Aug 2, 2019
4465d06
Add generated changelog entries
gatesn Aug 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests to not use project
  • Loading branch information
@gatesn
gatesn committed Aug 2, 2019
commit 24c16a493c31c0cb3f6dc6091049b63c2382d334
2 changes: 1 addition & 1 deletion ...eline-java/src/main/groovy/com/palantir/baseline/tasks/CheckImplicitDependenciesTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public final void checkImplicitDependencies() {
.filter(artifact -> !shouldIgnore(artifact))
.collect(Collectors.toList());
if (!usedButUndeclared.isEmpty()) {
// TODO(dfox): suggest project(':project-name') when a jar actually comes from this project!
// TODO(dfox): #123 - suggest project(':project-name') when a jar actually comes from this project!
String suggestion = usedButUndeclared.stream()
.map(artifact -> String.format(" implementation '%s:%s'",
artifact.getModuleVersion().getId().getGroup(),
Expand Down
6 changes: 3 additions & 3 deletions gradle-baseline-java/src/test/groovy/com/palantir/baseline/BaselineIdeaTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ class BaselineIdeaTest extends Specification {
project.plugins.hasPlugin(BaselineIdea.class)
}

def testGitHubUriExtraction(String remote, String project) {
def testGitHubUriExtraction(String remoteUri, String projectUri) {
expect:
assert BaselineIdea.gitHubProjectFromRemote(new URIish(remote)) == project
assert BaselineIdea.gitHubProjectFromRemote(new URIish(remoteUri)) == projectUri

where:
remote | project
remoteUri | projectUri
"git@github.com:palantir/gradle-baseline.git" | "https://github.com/palantir/gradle-baseline"
"git@github.my.company:palantir/gradle-baseline.git" | "https://github.my.company/palantir/gradle-baseline"
"https://github.com/palantir/gradle-baseline.git" | "https://github.com/palantir/gradle-baseline"
Expand Down