Skip to content

baseline-idea: configures IntelliJ EclipseCodeFormatter plugin #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bulldozer-bot merged 6 commits into from
Sep 9, 2019
Merged

baseline-idea: configures IntelliJ EclipseCodeFormatter plugin #794

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b50600e
automatically configure eclipse plugin
Sep 6, 2019
8f77174
Add generated changelog entries
Sep 6, 2019
791c4c9
Recommend both plugins
iamdanfox Sep 9, 2019
5bf21b4
Nits
iamdanfox Sep 9, 2019
8409959
Respect the feature flag
iamdanfox Sep 9, 2019
4623df9
Print warning if file doesn't exist
iamdanfox Sep 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Respect the feature flag
  • Loading branch information
@iamdanfox
iamdanfox committed Sep 9, 2019
commit 8409959d0a2b3ff386927da54bb8aeb166abfbc3
6 changes: 6 additions & 0 deletions gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineIdea.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,12 @@ class BaselineIdea extends AbstractBaselinePlugin {
project.logger.debug "Baseline: Skipping IDEA eclipse format configuration since baseline-format not applied"
return
}

if (!BaselineFormat.eclipseFormattingEnabled(project)) {
project.logger.debug "Baseline: Not configuring EclipseCodeFormatter because com.palantir.baseline-format.eclipse is not enabled in gradle.properties"
return
}

project.logger.debug "Baseline: Configuring EclipseCodeFormatter plugin for Idea"
node.append(new XmlParser().parseText("""
<component name="EclipseCodeFormatterProjectSettings">
Expand Down